linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pdc_adma: Last Patch to pdc_adma breaks debug compile[Scanned]
@ 2006-02-13  8:33 Seewer Philippe
  0 siblings, 0 replies; only message in thread
From: Seewer Philippe @ 2006-02-13  8:33 UTC (permalink / raw)
  To: jgarzik; +Cc: linux-ide

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]


The Last Patch (5. Nov. 05) to the sata pdc_adma driver removed nelem
from adma_fill_sg and introduced ata_for_each_sg.

The Problem is that nelem was forgot to be removed from the contained
VPRINTK too. The attached patch fixes this.

Patch applies against 2.6.15.1

Signed-Off-By: Seewer Philippe <philippe.seewer@bfh.ch>
---

--- linux-2.6.15.1/drivers/scsi/pdc_adma.c.orig 2006-02-08
09:03:15.000000000 +0100
+++ linux-2.6.15.1/drivers/scsi/pdc_adma.c      2006-02-08
09:04:32.000000000 +0100
@@ -322,8 +322,8 @@ static int adma_fill_sg(struct ata_queue
                        = (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma
+ i + 4);
                i += 4;

-               VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", nelem
-                                       (unsigned long)addr, len);
+               VPRINTK("Current PRD = (0x%lX, 0x%X)\n",
+                       (unsigned long)addr, len);
        }
        return i;
 }


[-- Attachment #2: pdc_adma.patch --]
[-- Type: text/x-patch, Size: 473 bytes --]

--- linux-2.6.15.1/drivers/scsi/pdc_adma.c.orig	2006-02-08 09:03:15.000000000 +0100
+++ linux-2.6.15.1/drivers/scsi/pdc_adma.c	2006-02-08 09:04:32.000000000 +0100
@@ -322,8 +322,8 @@ static int adma_fill_sg(struct ata_queue
 			= (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma + i + 4);
 		i += 4;
 
-		VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", nelem
-					(unsigned long)addr, len);
+		VPRINTK("Current PRD = (0x%lX, 0x%X)\n",
+			(unsigned long)addr, len);
 	}
 	return i;
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-02-13  8:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-13  8:33 [PATCH] pdc_adma: Last Patch to pdc_adma breaks debug compile[Scanned] Seewer Philippe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).