Re: [PATCH] Replace assert() with WARN_ON in drivers/scsi/libata-core.c

[Aubin LaBrosse <aubin@stormboxes.com>]

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

Randy.Dunlap wrote:
> On Mon, 13 Feb 2006, Aubin LaBrosse wrote:
>
>   
>> Replace assert() with WARN_ON in drivers/scsi/libata-core.c
>>
>> This is my first patch to the kernel - this work was suggested by Jeff Garzik as a janitorial task for libata.  If I could get some feedback letting me know that this is the correct format and my tools are setup right, I'll do the rest of these.
>>
>> Signed-off-by: Aubin LaBrosse <aubin@stormboxes.com>
>>     
>
> Jeff wrote an email a couple of days ago that he already has
> several of these patches...
>
>   
>> @@ -1251,8 +1251,8 @@ static void ata_dev_identify(struct ata_
>>
>>  	DPRINTK("ENTER, host %u, dev %u\n", ap->id, device);
>>
>> -	assert (dev->class == ATA_DEV_ATA || dev->class == ATA_DEV_ATAPI ||
>> -		dev->class == ATA_DEV_NONE);
>> +	WARN_ON(dev->class != ATA_DEV_ATA &&&dev->class != ATA_DEV_ATAPI &&
>> +		dev->class != ATA_DEV_NONE);
>>     
>
> Does that one compile cleanly?
>
>   
>>  	ata_dev_select(ap, device, 1, 1); /* select device 0/1 */
>>
>>     
>
> Otherwise it looks pretty good to me.
>
>   
Oops.  I guess it wouldn't have compiled. :(  I was so fixated on 
getting the tools to work right I didn't even try.  thanks for the 
feedback, even if someone beat me to it. guess i'll go check out 
kernelnewbies for other janitorial type stuff to work on (and won't 
forget to compile and boot-test my patches, sorry!)


-aubin

[-- Attachment #2: aubin.vcf --]
[-- Type: text/x-vcard, Size: 160 bytes --]

begin:vcard
fn:Aubin LaBrosse
n:LaBrosse;Aubin
email;internet:aubin@stormboxes.com
tel;work:589-0692
tel;home:429-1520
tel;cell:493-0121
version:2.1
end:vcard