linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Erik Mouw <erik@harddisk-recovery.com>
Cc: Mark Lord <liml@rtr.ca>, linux-ide@vger.kernel.org
Subject: Re: TASKFILE ioctl for libata?
Date: Wed, 15 Feb 2006 21:20:46 -0500	[thread overview]
Message-ID: <43F3E17E.1090701@pobox.com> (raw)
In-Reply-To: <20060216005643.GA28396@harddisk-recovery.com>

Erik Mouw wrote:
> On Wed, Feb 15, 2006 at 02:00:46PM -0500, Mark Lord wrote:
> 
>>Erik Mouw wrote:
>>
>>>Hdparm (6.3) needs the TASKFILE ioctl for the ATA security feature set
>>>(security freeze, security unlock, etc.). I can't find it in Jeff's
>>>libata-dev tree, is there somebody already working on it? Or is there a
>>>workaround?
>>
>>If that ioctl is missing in libata, then I'll have to convert hdparm
>>to use SGIO to submit ATA Passthru packets instead for libata devices.
> 
> 
> If SGIO can be used for ATA Passthru, then why are the HDIO_DRIVE_CMD
> and HDIO_DRIVE_TASK ioctl()s implemented in libata? AFAICS, the same
> functionality can be accomplished through SGIO ATA Passthru.

For compatibility :)  The HDIO compat ioctls are implemented internally 
via the ATA passthru SCSI command.

Although in general I resist adding compat ioctls, I think avoiding 
TASKFILE when we have TASK/CMD ioctls would be inconsistent.  If 
somebody wants to submit a tested patch...

	Jeff




  reply	other threads:[~2006-02-16  2:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-15 14:34 TASKFILE ioctl for libata? Erik Mouw
2006-02-15 19:00 ` Mark Lord
     [not found]   ` <a3d8b0a0602151257x52f6011bs1b37d9ac43b26619@mail.gmail.com>
2006-02-15 21:10     ` Matt Gillette
2006-02-16  0:06       ` Tejun Heo
2006-02-16  0:56   ` Erik Mouw
2006-02-16  2:20     ` Jeff Garzik [this message]
2006-02-16  9:30       ` Tejun Heo
2006-02-17  8:38         ` Jeff Garzik
2006-02-17  9:19           ` Tejun Heo
2006-02-17 14:50             ` Mark Lord
2006-02-17 17:17           ` Erik Mouw
2006-02-17 18:27           ` Timothy Thelin
2006-02-17 17:05         ` Erik Mouw
2006-02-17 17:15           ` Bartlomiej Zolnierkiewicz
2006-02-17 17:28             ` Erik Mouw
2006-02-17 18:13               ` Bartlomiej Zolnierkiewicz
2006-02-17 17:07       ` Erik Mouw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F3E17E.1090701@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=erik@harddisk-recovery.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).