From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/7] libata: separate out ata_dev_configure()
Date: Mon, 20 Feb 2006 05:37:58 -0500 [thread overview]
Message-ID: <43F99C06.8090306@pobox.com> (raw)
In-Reply-To: <1139995449220-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Separate out ata_dev_configure() from ata_dev_identify() such that
> ata_dev_configure() only configures @dev according to passed in @id.
> The function now does not disable device on failure, it just returns
> appropirate error code.
>
> As this change leaves ata_dev_identify() with only reading ID, calling
> configure and disabling devices according to the results, this patch
> also kills ata_dev_identify() and inlines the logic into
> ata_bus_probe().
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
ACK
prev parent reply other threads:[~2006-02-20 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 9:24 [PATCHSET] libata: reorganize ata_dev_identify() Tejun Heo
2006-02-15 9:24 ` [PATCH 6/7] libata: fold ata_dev_config() into ata_dev_configure() Tejun Heo
2006-02-20 10:41 ` Jeff Garzik
2006-02-15 9:24 ` [PATCH 2/7] libata: convert dev->id to pointer Tejun Heo
2006-02-15 9:24 ` [PATCH 7/7] libata: reorganize ata_bus_probe() Tejun Heo
2006-02-20 10:43 ` Jeff Garzik
2006-02-20 15:16 ` Tejun Heo
2006-02-15 9:24 ` [PATCH 4/7] libata: kill ata_dev_reread_id() Tejun Heo
2006-02-20 10:35 ` Jeff Garzik
2006-02-15 9:24 ` [PATCH 5/7] libata: separate out ata_dev_configure() Tejun Heo
2006-02-20 10:37 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F99C06.8090306@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).