From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 4/4] libata: revalidate after transfer mode configuration Date: Mon, 20 Feb 2006 05:51:47 -0500 Message-ID: <43F99F43.3020909@pobox.com> References: <11399977652003-git-send-email-htejun@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:25298 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S964871AbWBTKvu (ORCPT ); Mon, 20 Feb 2006 05:51:50 -0500 In-Reply-To: <11399977652003-git-send-email-htejun@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org Tejun Heo wrote: > Revalidate device after transfer mode configuration. This also makes > dev->id up-to-date. > > Signed-off-by: Tejun Heo > > --- > > drivers/scsi/libata-core.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > 4580280ce48d62d2d801cd427e6194f9ab56e84b > diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c > index 54ed8fd..c971c15 100644 > --- a/drivers/scsi/libata-core.c > +++ b/drivers/scsi/libata-core.c > @@ -1620,6 +1620,12 @@ static void ata_dev_set_mode(struct ata_ > idx = ofs + dev->xfer_shift; > WARN_ON(idx >= ARRAY_SIZE(xfer_mode_str)); > > + if (ata_dev_revalidate(ap, dev, 0)) { > + printk(KERN_ERR "ata%u: failed to revalidate after set " > + "xfermode, disabled\n", ap->id); > + ata_port_disable(ap); > + } why disable the entire port on error? Jeff