From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 7/7] libata: reorganize ata_bus_probe()
Date: Tue, 21 Feb 2006 00:16:06 +0900 [thread overview]
Message-ID: <43F9DD36.4050808@gmail.com> (raw)
In-Reply-To: <43F99D47.4060603@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>
>> Now that reset and configure are converted such that they don't modify
>> or disable libata core data structures, reorganize ata_bus_probe() to
>> reflect this change.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>
>
> the legacy phy_reset code path appears to call ata_port_probe() a second
> time. otherwise, seems OK.
>
Hello, Jeff.
That is intentional. ->phy_reset disables port if something goes wrong
during reset while the new model just offlines affected devices. The
code there emulates new behavior by turning off all devices and enabling
the port if the port gets disabled during ->phy_reset.
--
tejun
next prev parent reply other threads:[~2006-02-20 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 9:24 [PATCHSET] libata: reorganize ata_dev_identify() Tejun Heo
2006-02-15 9:24 ` [PATCH 7/7] libata: reorganize ata_bus_probe() Tejun Heo
2006-02-20 10:43 ` Jeff Garzik
2006-02-20 15:16 ` Tejun Heo [this message]
2006-02-15 9:24 ` [PATCH 4/7] libata: kill ata_dev_reread_id() Tejun Heo
2006-02-20 10:35 ` Jeff Garzik
2006-02-15 9:24 ` [PATCH 5/7] libata: separate out ata_dev_configure() Tejun Heo
2006-02-20 10:37 ` Jeff Garzik
2006-02-15 9:24 ` [PATCH 6/7] libata: fold ata_dev_config() into ata_dev_configure() Tejun Heo
2006-02-20 10:41 ` Jeff Garzik
2006-02-15 9:24 ` [PATCH 2/7] libata: convert dev->id to pointer Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F9DD36.4050808@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).