Re: [PATCH 4/4] libata: revalidate after transfer mode configuration

[Jeff Garzik <jgarzik@pobox.com>]

Tejun Heo wrote:
> Jeff Garzik wrote:
> 
>> Tejun Heo wrote:
>>
>>> Revalidate device after transfer mode configuration.  This also makes
>>> dev->id up-to-date.
>>>
>>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>>
>>> ---
>>>
>>>  drivers/scsi/libata-core.c |    6 ++++++
>>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> 4580280ce48d62d2d801cd427e6194f9ab56e84b
>>> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
>>> index 54ed8fd..c971c15 100644
>>> --- a/drivers/scsi/libata-core.c
>>> +++ b/drivers/scsi/libata-core.c
>>> @@ -1620,6 +1620,12 @@ static void ata_dev_set_mode(struct ata_
>>>      idx = ofs + dev->xfer_shift;
>>>      WARN_ON(idx >= ARRAY_SIZE(xfer_mode_str));
>>>  
>>> +    if (ata_dev_revalidate(ap, dev, 0)) {
>>> +        printk(KERN_ERR "ata%u: failed to revalidate after set "
>>> +               "xfermode, disabled\n", ap->id);
>>> +        ata_port_disable(ap);
>>> +    }
>>
>>
>>
>> why disable the entire port on error?
>>
> 
> Because that's what ata_set_mode() and its descendants does currently. 
> They disable port on failure. I didn't want to introduce new behavior 
> with this patch. The port disable -> device disable conversion will be 
> done in later patch series together with all other parts of 
> ata_set_mode(). No?

OK