From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, hellan@acm.org,
Carlos.Pardo@siliconimage.com, Raymond.Liu@siliconimage.com
Subject: Re: [PATCH 3/3] sata_sil: clean up and add errata/workaround documentation
Date: Sat, 25 Feb 2006 16:36:52 +0900 [thread overview]
Message-ID: <44000914.4050207@gmail.com> (raw)
In-Reply-To: <4400074F.3020005@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>
>> This patch collects into one place/update errata documentattion and
>> adds description of 3114 R_ERR on DMA activate FIS errata.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>
>> ---
>>
>> drivers/scsi/sata_sil.c | 97
>> ++++++++++++++++++++++++++++++++++++-----------
>> 1 files changed, 75 insertions(+), 22 deletions(-)
>>
>> 6b1cc9dff33ae20157946ae8b06f1a11079b4af6
>> diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c
>> index 9face3c..75784cd 100644
>> --- a/drivers/scsi/sata_sil.c
>> +++ b/drivers/scsi/sata_sil.c
>> @@ -30,8 +30,79 @@
>> * Documentation for SiI 3112:
>> *
>> http://gkernel.sourceforge.net/specs/sii/3112A_SiI-DS-0095-B2.pdf.bz2
>> *
>> + * Documentation for SiI 3114:
>> + * http://gkernel.sourceforge.net/specs/sii/sii-0680a-v1.31.pdf.bz2
>> + *
>> * Other errata and documentation available under NDA.
>
>
> I'll apply patches 1-2.
>
> For this patch #3, two comments:
>
> * the above URL points to CMD680 docs, not 3114
Oops. :-p
>
> * I'm unconvinced that long exposition should be in the .c file. I
> think its far better to put it into Documentation/DocBook/libata.tmpl. I
> have some long term plans to add more hardware details to the docbook
> docs, infact.
Hmmm... I don't know. You know I'm not a big fan of docbook docs mainly
because of accessibility. It's your call. Anyways, it would be nice to
keep up-to-date information regarding libata hardware quirks in some
easily-accessible place (wiki?).
--
tejun
next prev parent reply other threads:[~2006-02-25 7:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-25 4:52 [PATCHSET, RESEND] sata_sil: R_ERR on DMA activate FIS errata workaround Tejun Heo
2006-02-25 4:52 ` [PATCH 2/3] sata_sil: implement R_ERR on DMA activate FIS errata fix Tejun Heo
2006-02-25 4:52 ` [PATCH 1/3] sata_sil: add board ID for 3512 Tejun Heo
2006-02-25 4:52 ` [PATCH 3/3] sata_sil: clean up and add errata/workaround documentation Tejun Heo
2006-02-25 7:29 ` Jeff Garzik
2006-02-25 7:36 ` Tejun Heo [this message]
2006-02-25 22:07 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-02-25 4:30 [PATCHSET] sata_sil: R_ERR on DMA activate FIS errata workaround Tejun Heo
2006-02-25 4:30 ` [PATCH 3/3] sata_sil: clean up and add errata/workaround documentation Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44000914.4050207@gmail.com \
--to=htejun@gmail.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=Raymond.Liu@siliconimage.com \
--cc=hellan@acm.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).