From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <lkml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>,
David Greaves <david@dgreaves.com>,
Justin Piszcz <jpiszcz@lucidpixels.com>,
linux-kernel@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>,
albertcc@tw.ibm.com, axboe@suse.de,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: LibPATA code issues / 2.6.15.4
Date: Tue, 28 Feb 2006 10:33:00 +0900 [thread overview]
Message-ID: <4403A84C.6010804@gmail.com> (raw)
In-Reply-To: <4403704E.4090109@rtr.ca>
Hello, Mark.
Mark Lord wrote:
>
> .. hold off on 2.6.16 because of this or not?
>
It certainly is dangerous. I guess we should turn off FUA for the time
being. Barrier auto-fallback was once implemented but it didn't seem
like a good idea as it was too complex and hides low level bug from
higher level. The concensus seems to be developing blacklist of drives
which lie about FUA support (currently only one drive). Official kernel
doesn't seem to be the correct place to grow the blacklist, Maybe we
should do it from -mm?
>>
>> Well, no doubt whatsoever about it being a "regression",
>> since the FUA code is *new* in 2.6.16 (not present in 2.6.15).
>>
>> The FUA code should either get fixed, or removed from 2.6.16.
>
>
> Actually, now that I've done a little more digging, this FUA stuff
> is inherently dangerous as implemented. A least a few SATA controllers
> including pipelines and whatnot that rely upon recognizing the (S)ATA
> opcodes being using. And I sincerely doubt that any of those will
> recognize the very newish (and aptly named..) FUA opcodes.
>
> These may be unsafe in general, unless we tag controllers as
> FUA-capable and NON-FUA-capable, in addition to tagging the drives.
All sii controllers and piix/ahci seem to handle FUA pretty ok. And
yeah, we may have to create controller blacklist too.
BTW, can you let me know what drive we're talking about now (model name
and firmware revision)?
--
tejun
next prev parent reply other threads:[~2006-02-28 1:33 UTC|newest]
Thread overview: 163+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0602140439580.3567@p34>
2006-02-14 14:50 ` LibPATA code issues / 2.6.15.4 Mark Lord
2006-02-14 16:27 ` David Greaves
2006-02-14 17:12 ` Justin Piszcz
2006-02-14 18:00 ` Mark Lord
2006-02-14 18:06 ` Justin Piszcz
2006-02-23 23:39 ` Justin Piszcz
2006-02-25 15:32 ` Mark Lord
2006-02-25 15:58 ` Justin Piszcz
2006-02-25 16:11 ` Jesper Juhl
2006-02-25 16:21 ` Mark Lord
2006-02-25 11:34 ` David Greaves
2006-02-25 16:20 ` Mark Lord
2006-02-25 17:45 ` Justin Piszcz
2006-02-25 18:28 ` Mark Lord
2006-02-25 18:55 ` Justin Piszcz
2006-02-25 19:29 ` Justin Piszcz
2006-02-25 19:53 ` David Greaves
2006-02-25 19:47 ` David Greaves
2006-02-26 2:27 ` Mark Lord
2006-02-26 9:56 ` David Greaves
2006-02-26 14:04 ` Mark Lord
2006-02-27 21:34 ` Mark Lord
2006-02-28 1:33 ` Tejun Heo [this message]
2006-02-28 1:46 ` Linus Torvalds
2006-02-28 2:07 ` Jeff Garzik
2006-02-28 2:14 ` Linus Torvalds
2006-02-28 2:52 ` Jeff Garzik
2006-02-28 3:36 ` Jeff Garzik
2006-02-28 4:11 ` Mark Lord
2006-02-28 10:30 ` Alan Cox
2006-02-28 8:03 ` Jens Axboe
2006-02-28 4:16 ` Mark Lord
2006-02-28 10:32 ` Alan Cox
2006-02-28 10:30 ` Justin Piszcz
2006-02-28 10:39 ` David Greaves
2006-02-28 14:37 ` Mark Lord
2006-02-28 21:04 ` Bill Davidsen
2006-03-08 2:57 ` Mark Lord
2006-03-08 3:18 ` Dave Jones
2006-03-08 3:23 ` Mark Lord
2006-03-08 15:37 ` Bill Davidsen
2006-02-28 14:38 ` Mark Lord
[not found] ` <Pine.LNX.4.64.0602280939280.16541@p34>
2006-02-28 14:49 ` Mark Lord
2006-02-28 15:07 ` Jeff Garzik
2006-02-28 15:26 ` Mark Lord
2006-02-28 15:33 ` Jeff Garzik
2006-03-01 0:46 ` Mark Lord
2006-03-01 6:01 ` Jeff Garzik
2006-02-28 15:16 ` Alan Cox
2006-03-01 17:33 ` David Greaves
2006-03-01 18:37 ` Alan Cox
2006-03-01 20:12 ` Phillip Susi
2006-03-08 16:46 ` Alan Cox
2006-02-28 15:31 ` Mark Lord
2006-02-28 15:34 ` Jeff Garzik
2006-02-28 16:57 ` Eric D. Mudama
2006-03-01 1:04 ` Mark Lord
2006-03-01 11:37 ` Justin Piszcz
2006-03-01 13:17 ` Justin Piszcz
2006-03-01 17:41 ` David Greaves
2006-03-01 17:46 ` Mark Lord
2006-03-01 18:12 ` David Greaves
2006-03-01 18:30 ` Mark Lord
2006-03-01 18:32 ` Justin Piszcz
2006-03-01 18:33 ` Justin Piszcz
2006-03-01 18:48 ` David Greaves
2006-03-01 19:49 ` David Greaves
2006-03-03 19:38 ` Justin Piszcz
2006-03-03 22:46 ` David Greaves
2006-03-04 14:25 ` Mark Lord
2006-03-06 6:13 ` David Greaves
2006-03-21 18:11 ` David Greaves
2006-03-22 15:23 ` David Greaves
2006-03-05 11:43 ` Justin Piszcz
2006-03-05 12:41 ` Justin Piszcz
2006-03-05 22:58 ` Mark Lord
2006-03-05 23:00 ` Mark Lord
2006-03-05 23:19 ` Justin Piszcz
2006-03-05 23:39 ` Jeff Garzik
2006-04-21 19:14 ` LibPATA code issues / 2.6.16 (previously, 2.6.15.x) Justin Piszcz
2006-04-21 19:18 ` Jeff Garzik
2006-04-21 19:28 ` Linus Torvalds
2006-04-21 22:46 ` Jeff Garzik
2006-04-22 0:05 ` Linus Torvalds
2006-05-06 15:09 ` [smartmontools-support]Re: " Leon Woestenberg
2006-05-07 12:44 ` Ingo Oeser
2006-06-11 11:13 ` Justin Piszcz
2006-04-22 16:39 ` Justin Piszcz
2006-03-01 19:06 ` LibPATA code issues / 2.6.15.4 Justin Piszcz
2006-03-01 19:28 ` Mark Lord
2006-03-01 19:35 ` Mark Lord
2006-03-01 19:38 ` Justin Piszcz
2006-03-01 19:41 ` Jeff Garzik
2006-02-26 12:27 ` James Courtier-Dutton
2006-02-26 12:55 ` David Greaves
2006-02-26 13:56 ` Mark Lord
2006-02-26 14:30 ` Kernel SeekCompleteErrors... Different from " James Courtier-Dutton
2006-02-26 17:03 ` Mark Lord
2006-02-26 17:13 ` Dr. David Alan Gilbert
2006-02-26 17:43 ` Alan Cox
2006-02-26 20:36 ` Mark Lord
2006-02-27 11:48 ` Alan Cox
2006-02-27 13:40 ` Mark Lord
2006-02-14 23:58 ` Justin Piszcz
2006-02-17 8:45 ` Jeff Garzik
2006-02-17 14:59 ` Mark Lord
2006-02-17 15:00 ` Justin Piszcz
2006-02-18 20:43 ` Sander
2006-02-18 21:42 ` Mark Lord
2006-02-18 21:51 ` Justin Piszcz
2006-02-19 7:14 ` Sander
2006-02-19 15:30 ` Mark Lord
2006-02-19 17:16 ` Sander
2006-07-06 23:08 ` Justin Piszcz
2006-07-07 13:08 ` Mark Lord
2006-07-07 13:24 ` Justin Piszcz
2006-07-07 13:43 ` Mark Lord
2006-07-07 13:48 ` Justin Piszcz
2006-07-07 14:01 ` Justin Piszcz
2006-07-07 14:35 ` Justin Piszcz
2006-07-07 18:53 ` Justin Piszcz
2006-07-07 19:19 ` Jeff Garzik
2006-07-07 19:28 ` Justin Piszcz
[not found] ` <200607091224.31451.liml@rtr.ca>
2006-07-09 17:27 ` Justin Piszcz
2006-07-09 20:16 ` Justin Piszcz
2006-07-09 20:40 ` LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Justin Piszcz
2006-07-09 20:46 ` Justin Piszcz
2006-07-09 21:05 ` Justin Piszcz
2006-07-09 22:03 ` Justin Piszcz
2006-07-10 13:59 ` Follow up? " Justin Piszcz
2006-07-10 15:33 ` Alan Cox
2006-07-10 15:45 ` Justin Piszcz
2006-07-11 13:28 ` LibPATA code issues / 2.6.17.3 (What is the next step?) Justin Piszcz
2006-07-11 16:12 ` Alan Cox
2006-07-12 22:10 ` David Greaves
2006-07-12 22:29 ` Justin Piszcz
2006-07-14 15:33 ` David Greaves
2006-07-13 10:55 ` Erik Mouw
2006-07-14 17:16 ` Mark Lord
2006-07-14 17:18 ` Justin Piszcz
2006-07-14 17:39 ` Mark Lord
2006-07-14 18:18 ` Justin Piszcz
2006-07-14 20:02 ` Mark Lord
2006-07-14 17:14 ` Follow up? LibPATA code issues / 2.6.15.4 (found the opcode=0x35)! Mark Lord
2006-07-14 17:17 ` Justin Piszcz
2006-07-14 17:37 ` Mark Lord
2006-07-14 18:17 ` Justin Piszcz
2006-03-01 19:00 LibPATA code issues / 2.6.15.4 Nicolas Mailhot
2006-03-01 19:22 ` Mark Lord
2006-03-01 23:12 ` Nicolas Mailhot
2006-03-01 23:31 ` Jeff Garzik
2006-03-02 1:19 ` Eric D. Mudama
2006-03-02 1:39 ` Eric D. Mudama
-- strict thread matches above, loose matches on Subject: below --
2006-03-14 13:50 me_trash1
2006-03-15 15:03 ` Mark Lord
2006-03-16 10:08 ` Jens Axboe
2006-03-17 5:26 ` Mark Lord
2006-03-17 9:26 ` Albert Lee
2006-03-17 9:57 ` Jeff Garzik
2006-03-17 15:20 ` Eric D. Mudama
2006-03-17 15:20 ` Mark Lord
2006-03-17 15:29 ` Tejun Heo
2006-03-16 0:19 ` markus ebenhoeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4403A84C.6010804@gmail.com \
--to=htejun@gmail.com \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=david@dgreaves.com \
--cc=jgarzik@pobox.com \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).