From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: LibPATA code issues / 2.6.15.4 Date: Mon, 27 Feb 2006 21:52:31 -0500 Message-ID: <4403BAEF.1000908@pobox.com> References: <43F2050B.8020006@dgreaves.com> <200602141300.37118.lkml@rtr.ca> <440040B4.8030808@dgreaves.com> <440083B4.3030307@rtr.ca> <4400A1BF.7020109@rtr.ca> <4400B439.8050202@dgreaves.com> <4401122A.3010908@rtr.ca> <44017B4B.3030900@dgreaves.com> <4401B560.40702@rtr.ca> <4403704E.4090109@rtr.ca> <4403A84C.6010804@gmail.com> <4403B04F.5090405@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:63203 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751128AbWB1Cwl (ORCPT ); Mon, 27 Feb 2006 21:52:41 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Linus Torvalds Cc: Tejun Heo , Mark Lord , David Greaves , Justin Piszcz , linux-kernel@vger.kernel.org, IDE/ATA development list , albertcc@tw.ibm.com, axboe@suse.de Linus Torvalds wrote: > > On Mon, 27 Feb 2006, Jeff Garzik wrote: > >>I've had this waiting in the wings, in fact... [see attached] > > > I really hate having a _global_ variable called "fua". That's just bad > taste. I would suggest calling it "atapi_forced_unit_attention_enabled", > but maybe that is going a bit overboard. It's definitely better than just > "fua", though. It will go away when things are fixed, and only users who are testing will even bother with it. Looking over the module subsystem, it looks like one could use module_param_named() to achieve proper namespace separation (C versus module opt) -- then you could call it libata_fua -- but for a temporary module option it seems like more trouble than its worth. Jeff