From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2/13] ATA ACPI: debugging infrastructure Date: Tue, 28 Feb 2006 07:00:14 -0500 Message-ID: <44043B4E.30907@pobox.com> References: <20060222133241.595a8509.randy_d_dunlap@linux.intel.com> <20060222135133.3f80fbf9.randy_d_dunlap@linux.intel.com> <20060228114500.GA4057@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:11652 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932203AbWB1MAR (ORCPT ); Tue, 28 Feb 2006 07:00:17 -0500 In-Reply-To: <20060228114500.GA4057@elf.ucw.cz> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Pavel Machek Cc: Randy Dunlap , lkml , linux-ide@vger.kernel.org, akpm@osdl.org Pavel Machek wrote: > I hate to see debugging infrastructure like this. We already have it > in ACPI and it is nasty/useless. It hides serious errors during normal > run, while if you turn on the debugging, it floods logs so that > it is unusable, too. I end up having to replace dprintks with > printks... nasty. Then you clearly don't understand what the code is doing. Fine-grained message selection allows one to turn on only the messages needed, and only for the controller desired. Otherwise, it is nearly impossible to debug one SATA controller while booting off another. Jeff