* Re: [PATCH 1/6] libata: separate out ata_dev_read_id()
[not found] <11404555313091-git-send-email-htejun@gmail.com>
@ 2006-02-21 0:01 ` Jeff Garzik
2006-02-28 16:56 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2006-02-21 0:01 UTC (permalink / raw)
To: Tejun Heo; +Cc: albertcc, linux-ide
Tejun Heo wrote:
> Separate out ata_dev_read_id() from ata_dev_identify(). This is the
> first half of splitting ata_dev_identify(). ata_dev_read_id() will
> also be used for revalidation. This patch does not make any behavior
> change.
>
> ata_dev_read_id() doesn't modify any of libata-internal data
> structures. It simply reads IDENTIFY page and returns error code on
> failure. INIT_DEV_PARAMS and EDD wrong class code are also handled by
> this function.
>
> Re-reading IDENTIFY after INIT_DEV_PARAMS is performed by jumping to
> retry: instead of calling ata_dev_reread_id(). This is done because
> 1. there's retry label anyway 2. ata_dev_reread_id() cannot be used
> anywhere else so there's no reason to keep it.
>
> This function is probably the place to set transfer mode to PIO0
> before IDENTIFY. However, reset -> identify -> init_dev_params order
> should be kept for pre-ATA4 devices so we cannot set transfer mode
> before IDENTIFY for them. How do we know if a device is post-ATA4
> before IDENTIFY?
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied 1-2, will get to the rest a bit later, after other work and some
testing of this work.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/6] libata: separate out ata_dev_read_id()
2006-02-21 0:01 ` [PATCH 1/6] libata: separate out ata_dev_read_id() Jeff Garzik
@ 2006-02-28 16:56 ` Tejun Heo
2006-02-28 3:15 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2006-02-28 16:56 UTC (permalink / raw)
To: Jeff Garzik; +Cc: albertcc, linux-ide
Jeff Garzik wrote:
> Tejun Heo wrote:
>
>> Separate out ata_dev_read_id() from ata_dev_identify(). This is the
>> first half of splitting ata_dev_identify(). ata_dev_read_id() will
>> also be used for revalidation. This patch does not make any behavior
>> change.
>>
>> ata_dev_read_id() doesn't modify any of libata-internal data
>> structures. It simply reads IDENTIFY page and returns error code on
>> failure. INIT_DEV_PARAMS and EDD wrong class code are also handled by
>> this function.
>>
>> Re-reading IDENTIFY after INIT_DEV_PARAMS is performed by jumping to
>> retry: instead of calling ata_dev_reread_id(). This is done because
>> 1. there's retry label anyway 2. ata_dev_reread_id() cannot be used
>> anywhere else so there's no reason to keep it.
>>
>> This function is probably the place to set transfer mode to PIO0
>> before IDENTIFY. However, reset -> identify -> init_dev_params order
>> should be kept for pre-ATA4 devices so we cannot set transfer mode
>> before IDENTIFY for them. How do we know if a device is post-ATA4
>> before IDENTIFY?
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
>
> applied 1-2, will get to the rest a bit later, after other work and some
> testing of this work.
Hello, Jeff.
How is this going? Just checking as it's been more than a week.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-28 3:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <11404555313091-git-send-email-htejun@gmail.com>
2006-02-21 0:01 ` [PATCH 1/6] libata: separate out ata_dev_read_id() Jeff Garzik
2006-02-28 16:56 ` Tejun Heo
2006-02-28 3:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).