From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ahci: add softreset
Date: Tue, 28 Feb 2006 13:12:38 -0500 [thread overview]
Message-ID: <44049296.10006@pobox.com> (raw)
In-Reply-To: <20060215063659.GB9621@htj.dyndns.org>
Tejun Heo wrote:
> Now that libata is smart enought to handle both soft and hard resets,
> add softreset method.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
ACK, finally
(though I am dropping all your other pending patches as requested)
> + /* spec says at least 5us, but be generous and sleep for 1ms */
> + msleep(1);
FWIW msleep simply guarantees a minimum delay. Depending on the
scheduler tick granularity, msleep(1) may delay 10-100ms.
This FWIW may or may not warrant updating the above comment, I leave it
up to you.
Jeff
next prev parent reply other threads:[~2006-02-28 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 7:26 [PATCHSET] ahci: convert to new reset mechanism Tejun Heo
2006-02-11 7:26 ` [PATCH 2/3] " Tejun Heo
2006-02-11 7:26 ` [PATCH 1/3] ahci: make ahci_fill_cmd_slot() take *pp instead of *ap Tejun Heo
2006-02-11 22:53 ` Jeff Garzik
2006-02-11 7:26 ` [PATCH 3/3] ahci: add softreset Tejun Heo
2006-02-11 23:27 ` Jeff Garzik
2006-02-12 4:58 ` Tejun
2006-02-15 6:36 ` [PATCH] " Tejun Heo
2006-02-28 18:12 ` Jeff Garzik [this message]
2006-03-01 5:35 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2005-12-12 4:09 [PATCH] AHCI SATA vendor update from VIA Jeff Garzik
2006-03-15 16:17 ` Sergey Vlasov
2006-03-21 1:53 ` Jeff Garzik
2006-03-21 11:19 ` Tejun Heo
2006-03-21 16:39 ` Jeff Garzik
2006-03-22 12:07 ` [PATCH] ahci: add softreset Tejun Heo
2006-03-23 0:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44049296.10006@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).