From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: LibPATA code issues / 2.6.15.4 Date: Wed, 01 Mar 2006 01:01:58 -0500 Message-ID: <440538D6.3010803@pobox.com> References: <43F2050B.8020006@dgreaves.com> <200602141300.37118.lkml@rtr.ca> <440040B4.8030808@dgreaves.com> <440083B4.3030307@rtr.ca> <4400A1BF.7020109@rtr.ca> <4400B439.8050202@dgreaves.com> <4401122A.3010908@rtr.ca> <44017B4B.3030900@dgreaves.com> <4401B560.40702@rtr.ca> <4403704E.4090109@rtr.ca> <4403A84C.6010804@gmail.com> <4403CEA9.4080603@rtr.ca> <44042863.2050703@dgreaves.com> <44046074.4070201@rtr.ca> <440462E1.2010909@rtr.ca> <4404671D.70506@pobox.com> <44046BBF.1060204@rtr.ca> <44046D65.90909@pobox.com> <4404EECE.3080304@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.dvmed.net ([216.237.124.58]:50854 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932421AbWCAGCF (ORCPT ); Wed, 1 Mar 2006 01:02:05 -0500 In-Reply-To: <4404EECE.3080304@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: Justin Piszcz , IDE/ATA development list Mark Lord wrote: > Jeff Garzik wrote: > >> >>>> Nah we should really dump the full taskfile... >>> >>> >>> >>> Agreed. But the original command byte is not stored anywhere >>> for us to dump it from. >> >> >> er eh? >> >> All callers of ata_to_sense_error() have the full taskfile available. > > > Yes, but the command byte gets overwritten by the read-back status byte, > since they share the same byte in the taskfile. > > So once the command has failed, the command byte is no longer there. It's trivial to save it locally before stomping... Jeff