From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>, ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] rate-limit libata-scsi status/error message
Date: Wed, 01 Mar 2006 15:43:07 -0500 [thread overview]
Message-ID: <4406075B.5050904@pobox.com> (raw)
In-Reply-To: <43F72B70.5040107@rtr.ca>
Mark Lord wrote:
> Randy.Dunlap wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> Rate-limit a translated ATA status/error message.
>> I have a kernel log that is 2/3 full of these messages
>> due to a CD/DVD drive being empty.
>
> ...
>
>> - printk(KERN_ERR "ata%u: translated ATA stat/err 0x%02x/%02x to "
>> - "SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n", id, drv_stat, drv_err,
>> - *sk, *asc, *ascq);
>> + if (printk_ratelimit())
>> + printk(KERN_ERR "ata%u: translated ATA stat/err 0x%02x/%02x to "
>> + "SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n",
>> + id, drv_stat, drv_err, *sk, *asc, *ascq);
>
>
> That message shouldn't even be enabled for non DEBUG cases.
> I suspect Jeff will remove it for 2.6.17..
Kinda sorta: ATAPI errors are still shaking out, in a big way. Under
ATA, almost any error should be reported. Under ATAPI, certain classes
of errors are quite normal, and should not fill the logs with spam.
The proper fix is to avoid reporting errors for those few ATAPI cases
that occur in normal operation, rather than ratelimiting all libata
error messages.
IOW don't report an error, when it isn't really an error...
Jeff
prev parent reply other threads:[~2006-03-01 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 5:37 [PATCH] rate-limit libata-scsi status/error message Randy.Dunlap
2006-02-18 14:13 ` Mark Lord
2006-03-01 20:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4406075B.5050904@pobox.com \
--to=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).