* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 1:58 ` Jeff Garzik
@ 2006-03-02 2:20 ` Eric D. Mudama
2006-03-02 2:46 ` Jeff Garzik
2006-03-02 16:05 ` Nicolas Mailhot
2006-03-02 7:22 ` Jens Axboe
2006-03-02 15:59 ` Nicolas Mailhot
2 siblings, 2 replies; 27+ messages in thread
From: Eric D. Mudama @ 2006-03-02 2:20 UTC (permalink / raw)
To: Jeff Garzik
Cc: Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord, linux-ide,
linux-kernel, Carlos Pardo
On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
> This also begs the question... what controller was being used, when the
> single Maxtor device listed in the blacklist was added? Perhaps it was
> a problem with the controller, not the device.
>
> Jeff
As reported here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177951
the controller was a 3114, and the bug was "fixed" by blacklisting his
Maxtor drive's FUA support. I'd like Maxtor drives to be
un-blacklisted if possible.
--eric
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 2:20 ` Eric D. Mudama
@ 2006-03-02 2:46 ` Jeff Garzik
2006-03-02 3:00 ` Eric D. Mudama
2006-03-02 16:03 ` Nicolas Mailhot
2006-03-02 16:05 ` Nicolas Mailhot
1 sibling, 2 replies; 27+ messages in thread
From: Jeff Garzik @ 2006-03-02 2:46 UTC (permalink / raw)
To: Eric D. Mudama
Cc: Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord, linux-ide,
linux-kernel, Carlos Pardo
Eric D. Mudama wrote:
> On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
>
>>This also begs the question... what controller was being used, when the
>>single Maxtor device listed in the blacklist was added? Perhaps it was
>>a problem with the controller, not the device.
>>
>> Jeff
>
>
> As reported here:
>
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177951
>
> the controller was a 3114, and the bug was "fixed" by blacklisting his
> Maxtor drive's FUA support. I'd like Maxtor drives to be
> un-blacklisted if possible.
If its 3114 I agree un-blacklisting is the way to go... but its not
clear to me whether the problematic configuration included sata_sil or
sata_nv. Since I'm apparently blind :) which part of the bug points
conclusively to sata_sil?
Jeff
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 2:46 ` Jeff Garzik
@ 2006-03-02 3:00 ` Eric D. Mudama
2006-03-02 3:06 ` Jeff Garzik
2006-03-02 16:07 ` Nicolas Mailhot
2006-03-02 16:03 ` Nicolas Mailhot
1 sibling, 2 replies; 27+ messages in thread
From: Eric D. Mudama @ 2006-03-02 3:00 UTC (permalink / raw)
To: Jeff Garzik
Cc: Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord, linux-ide,
linux-kernel, Carlos Pardo
On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
> Eric D. Mudama wrote:
> > On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> >>This also begs the question... what controller was being used, when the
> >>single Maxtor device listed in the blacklist was added? Perhaps it was
> >>a problem with the controller, not the device.
> >>
> >> Jeff
> >
> >
> > As reported here:
> >
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177951
> >
> > the controller was a 3114, and the bug was "fixed" by blacklisting his
> > Maxtor drive's FUA support. I'd like Maxtor drives to be
> > un-blacklisted if possible.
>
> If its 3114 I agree un-blacklisting is the way to go... but its not
> clear to me whether the problematic configuration included sata_sil or
> sata_nv. Since I'm apparently blind :) which part of the bug points
> conclusively to sata_sil?
>
> Jeff
The "failing dmesg" has the plextor connected to sata_nv, and the two
Maxtor drives connected to sata_sil, if I read it correctly. They're
ata5/ata6 ports, mapped as sda/sdb.
Nicolas' comment in the thread "Re: LibPATA code issues / 2.6.15.4"
seemed to say it was the same adapter:
http://marc.theaimsgroup.com/?l=linux-kernel&m=114123989405668&w=2
--eric
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:00 ` Eric D. Mudama
@ 2006-03-02 3:06 ` Jeff Garzik
2006-03-02 3:13 ` Tejun Heo
` (2 more replies)
2006-03-02 16:07 ` Nicolas Mailhot
1 sibling, 3 replies; 27+ messages in thread
From: Jeff Garzik @ 2006-03-02 3:06 UTC (permalink / raw)
To: Eric D. Mudama
Cc: Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord, linux-ide,
linux-kernel, Carlos Pardo
Eric D. Mudama wrote:
> The "failing dmesg" has the plextor connected to sata_nv, and the two
> Maxtor drives connected to sata_sil, if I read it correctly. They're
> ata5/ata6 ports, mapped as sda/sdb.
>
> Nicolas' comment in the thread "Re: LibPATA code issues / 2.6.15.4"
> seemed to say it was the same adapter:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114123989405668&w=2
Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is the
way to go...
Jeff
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:06 ` Jeff Garzik
@ 2006-03-02 3:13 ` Tejun Heo
2006-03-02 3:16 ` Mark Lord
2006-03-02 16:12 ` Nicolas Mailhot
2 siblings, 0 replies; 27+ messages in thread
From: Tejun Heo @ 2006-03-02 3:13 UTC (permalink / raw)
To: Jeff Garzik
Cc: Eric D. Mudama, Jens Axboe, Nicolas Mailhot, Mark Lord, linux-ide,
linux-kernel, Carlos Pardo
Jeff Garzik wrote:
> Eric D. Mudama wrote:
>
>> The "failing dmesg" has the plextor connected to sata_nv, and the two
>> Maxtor drives connected to sata_sil, if I read it correctly. They're
>> ata5/ata6 ports, mapped as sda/sdb.
>>
>> Nicolas' comment in the thread "Re: LibPATA code issues / 2.6.15.4"
>> seemed to say it was the same adapter:
>>
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=114123989405668&w=2
>
>
> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is the
> way to go...
>
Agreed. I'm currently implementing VDMA on sata_sil and will get to FUA
via explicit protocol soon.
--
tejun
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:06 ` Jeff Garzik
2006-03-02 3:13 ` Tejun Heo
@ 2006-03-02 3:16 ` Mark Lord
2006-03-02 3:18 ` Jeff Garzik
2006-03-02 16:12 ` Nicolas Mailhot
2 siblings, 1 reply; 27+ messages in thread
From: Mark Lord @ 2006-03-02 3:16 UTC (permalink / raw)
To: Jeff Garzik
Cc: Eric D. Mudama, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Jeff Garzik wrote:
..
> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is the
> way to go...
Might as well add sata_mv to that blacklist as well.
And while I'm at it, the pdc_adma and sata_qstor controllers/drivers are fine with FUA.
-ml
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:16 ` Mark Lord
@ 2006-03-02 3:18 ` Jeff Garzik
2006-03-02 6:23 ` Eric D. Mudama
` (2 more replies)
0 siblings, 3 replies; 27+ messages in thread
From: Jeff Garzik @ 2006-03-02 3:18 UTC (permalink / raw)
To: Mark Lord
Cc: Eric D. Mudama, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Mark Lord wrote:
> Jeff Garzik wrote:
> ..
>
>> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is
>> the way to go...
>
>
> Might as well add sata_mv to that blacklist as well.
Have you confirmed that it doesn't work with FUA?
We recently patched sata_mv to add ATA_CMD_WRITE_FUA_EXT, in response to
a nasty bug report, and ISTR the complainer went away.
> And while I'm at it, the pdc_adma and sata_qstor controllers/drivers are
> fine with FUA.
Verified or just guessing?
Jeff
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:18 ` Jeff Garzik
@ 2006-03-02 6:23 ` Eric D. Mudama
2006-03-02 9:00 ` Sander
2006-03-02 11:52 ` Jeff Garzik
2006-03-02 8:57 ` Sander
2006-03-03 0:34 ` Mark Lord
2 siblings, 2 replies; 27+ messages in thread
From: Eric D. Mudama @ 2006-03-02 6:23 UTC (permalink / raw)
To: Jeff Garzik
Cc: Mark Lord, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
> Mark Lord wrote:
> > Jeff Garzik wrote:
> > ..
> >
> >> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is
> >> the way to go...
> >
> >
> > Might as well add sata_mv to that blacklist as well.
>
> Have you confirmed that it doesn't work with FUA?
I'll see if I can find one of these around the lab tomorrow and test
the raw command support. If that's fine at a basic level, it might be
a bug in the driver?
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 6:23 ` Eric D. Mudama
@ 2006-03-02 9:00 ` Sander
2006-03-02 11:52 ` Jeff Garzik
1 sibling, 0 replies; 27+ messages in thread
From: Sander @ 2006-03-02 9:00 UTC (permalink / raw)
To: Eric D. Mudama
Cc: Jeff Garzik, Mark Lord, Jens Axboe, Tejun Heo, Nicolas Mailhot,
Mark Lord, linux-ide, linux-kernel, Carlos Pardo
Eric D. Mudama wrote (ao):
> On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
> > Mark Lord wrote:
> > > Jeff Garzik wrote:
> > > ..
> > >
> > >> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is
> > >> the way to go...
> > >
> > >
> > > Might as well add sata_mv to that blacklist as well.
> >
> > Have you confirmed that it doesn't work with FUA?
>
> I'll see if I can find one of these around the lab tomorrow and test
> the raw command support. If that's fine at a basic level, it might be
> a bug in the driver?
If you tell me what to do (what to type in etc) I can save you from
looking for one. I have a:
Marvell Technology Group Ltd. MV88SX6081 8-port SATA II PCI-X Controller
(rev 09)
I can connect a Maxtor MaXLine Pro 500, a Maxtor DiamondMax11 and a WD
Raptor 74GB to test if necessary.
Sander
--
Humilis IT Services and Solutions
http://www.humilis.net
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 6:23 ` Eric D. Mudama
2006-03-02 9:00 ` Sander
@ 2006-03-02 11:52 ` Jeff Garzik
1 sibling, 0 replies; 27+ messages in thread
From: Jeff Garzik @ 2006-03-02 11:52 UTC (permalink / raw)
To: Eric D. Mudama
Cc: Mark Lord, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Eric D. Mudama wrote:
> On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
>
>>Mark Lord wrote:
>>
>>>Jeff Garzik wrote:
>>>..
>>>
>>>
>>>>Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is
>>>>the way to go...
>>>
>>>
>>>Might as well add sata_mv to that blacklist as well.
>>
>>Have you confirmed that it doesn't work with FUA?
>
>
> I'll see if I can find one of these around the lab tomorrow and test
> the raw command support. If that's fine at a basic level, it might be
> a bug in the driver?
Quite possibly. Anything goes with sata_mv at the moment... I've done
my best to cover most of the errata and get it working, but there are
still some key errata workarounds missing. It's still marked "HIGHLY
EXPERIMENTAL" in the Kconfig ;-)
Jeff
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:18 ` Jeff Garzik
2006-03-02 6:23 ` Eric D. Mudama
@ 2006-03-02 8:57 ` Sander
2006-03-03 0:34 ` Mark Lord
2 siblings, 0 replies; 27+ messages in thread
From: Sander @ 2006-03-02 8:57 UTC (permalink / raw)
To: Jeff Garzik
Cc: Mark Lord, Eric D. Mudama, Jens Axboe, Tejun Heo, Nicolas Mailhot,
Mark Lord, linux-ide, linux-kernel, Carlos Pardo
Jeff Garzik wrote (ao):
> Mark Lord wrote:
> >Jeff Garzik wrote:
> >..
> >
> >>Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is
> >>the way to go...
> >
> >
> >Might as well add sata_mv to that blacklist as well.
>
> Have you confirmed that it doesn't work with FUA?
>
> We recently patched sata_mv to add ATA_CMD_WRITE_FUA_EXT, in response to
> a nasty bug report, and ISTR the complainer went away.
That is correct. I was that complainer and reported that the patch works
for me: http://lkml.org/lkml/2006/2/15/175
Also, the patch went into the next -rc kernel that time.
Sander
PS, can I get you guys interested in the sata_mv driver? I would really
love to use Marvell controller:
http://www.ussg.iu.edu/hypermail/linux/kernel/0602.2/0914.html
I'd be very happy to test any patches and will report how they do.
--
Humilis IT Services and Solutions
http://www.humilis.net
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:18 ` Jeff Garzik
2006-03-02 6:23 ` Eric D. Mudama
2006-03-02 8:57 ` Sander
@ 2006-03-03 0:34 ` Mark Lord
2 siblings, 0 replies; 27+ messages in thread
From: Mark Lord @ 2006-03-03 0:34 UTC (permalink / raw)
To: Jeff Garzik
Cc: Mark Lord, Eric D. Mudama, Jens Axboe, Tejun Heo, Nicolas Mailhot,
linux-ide, linux-kernel, Carlos Pardo
Jeff Garzik wrote:
> Mark Lord wrote:
>> Jeff Garzik wrote:
>> ..
>>
>>> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is
>>> the way to go...
>>
>>
>> Might as well add sata_mv to that blacklist as well.
>
> Have you confirmed that it doesn't work with FUA?
Ooops. Defective memory here.
The Marvell documentation for the 6081/6041 does indeed state
that the FUA DMA commands *are* supported (queued or non-queued).
So it should be okay, at least for those two specific chips.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:06 ` Jeff Garzik
2006-03-02 3:13 ` Tejun Heo
2006-03-02 3:16 ` Mark Lord
@ 2006-03-02 16:12 ` Nicolas Mailhot
2 siblings, 0 replies; 27+ messages in thread
From: Nicolas Mailhot @ 2006-03-02 16:12 UTC (permalink / raw)
To: Jeff Garzik
Cc: Eric D. Mudama, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Le Jeu 2 mars 2006 04:06, Jeff Garzik a écrit :
> Eric D. Mudama wrote:
>> The "failing dmesg" has the plextor connected to sata_nv, and the two
>> Maxtor drives connected to sata_sil, if I read it correctly. They're
>> ata5/ata6 ports, mapped as sda/sdb.
>>
>> Nicolas' comment in the thread "Re: LibPATA code issues / 2.6.15.4"
>> seemed to say it was the same adapter:
>>
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=114123989405668&w=2
>
> Sounds like un-blacklisting the drive, and adding ATA_FLAG_NO_FUA is the
> way to go...
Please add the ATA_FLAG_NO_FUA flag and *after* unblacklist the drive as I
distinctly have no wish to do fsck stressing again.
--
Nicolas Mailhot
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 3:00 ` Eric D. Mudama
2006-03-02 3:06 ` Jeff Garzik
@ 2006-03-02 16:07 ` Nicolas Mailhot
1 sibling, 0 replies; 27+ messages in thread
From: Nicolas Mailhot @ 2006-03-02 16:07 UTC (permalink / raw)
To: Eric D. Mudama
Cc: Jeff Garzik, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Le Jeu 2 mars 2006 04:00, Eric D. Mudama a écrit :
> The "failing dmesg" has the plextor connected to sata_nv, and the two
> Maxtor drives connected to sata_sil, if I read it correctly. They're
> ata5/ata6 ports, mapped as sda/sdb.
>
> Nicolas' comment in the thread "Re: LibPATA code issues / 2.6.15.4"
> seemed to say it was the same adapter:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114123989405668&w=2
Not only it's the same adapter model, but we're talking about the same
physical system. I opened the original boog, posted on lkml, etc
--
Nicolas Mailhot
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 2:46 ` Jeff Garzik
2006-03-02 3:00 ` Eric D. Mudama
@ 2006-03-02 16:03 ` Nicolas Mailhot
1 sibling, 0 replies; 27+ messages in thread
From: Nicolas Mailhot @ 2006-03-02 16:03 UTC (permalink / raw)
To: Jeff Garzik
Cc: Eric D. Mudama, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Le Jeu 2 mars 2006 03:46, Jeff Garzik a écrit :
> Eric D. Mudama wrote:
> If its 3114 I agree un-blacklisting is the way to go... but its not
> clear to me whether the problematic configuration included sata_sil or
> sata_nv. Since I'm apparently blind :) which part of the bug points
> conclusively to sata_sil?
It's sata-sil
I'm 100% sure it's how I cabled the system
sata-nv only got a plextor drive attached
(pata-nv has two pata drives on too)
--
Nicolas Mailhot
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 2:20 ` Eric D. Mudama
2006-03-02 2:46 ` Jeff Garzik
@ 2006-03-02 16:05 ` Nicolas Mailhot
1 sibling, 0 replies; 27+ messages in thread
From: Nicolas Mailhot @ 2006-03-02 16:05 UTC (permalink / raw)
To: Eric D. Mudama
Cc: Jeff Garzik, Jens Axboe, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Le Jeu 2 mars 2006 03:20, Eric D. Mudama a écrit :
> On 3/1/06, Jeff Garzik <jgarzik@pobox.com> wrote:
>> This also begs the question... what controller was being used, when the
>> single Maxtor device listed in the blacklist was added? Perhaps it was
>> a problem with the controller, not the device.
>>
>> Jeff
>
> As reported here:
>
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177951
>
> the controller was a 3114, and the bug was "fixed" by blacklisting his
> Maxtor drive's FUA support. I'd like Maxtor drives to be
> un-blacklisted if possible.
BTW Eric you should know :
- these specific drives (and the Maxtor PATA drives they replaced) where
bought because I knew you were hanging on the lists
- I fully intended to ask you if the blacklisting where valif after the
FUA dust had settled a little
Regards,
--
Nicolas Mailhot
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 1:58 ` Jeff Garzik
2006-03-02 2:20 ` Eric D. Mudama
@ 2006-03-02 7:22 ` Jens Axboe
2006-03-02 15:59 ` Nicolas Mailhot
2 siblings, 0 replies; 27+ messages in thread
From: Jens Axboe @ 2006-03-02 7:22 UTC (permalink / raw)
To: Jeff Garzik
Cc: Eric D. Mudama, Tejun Heo, Nicolas Mailhot, Mark Lord, linux-ide,
linux-kernel, Carlos Pardo
On Wed, Mar 01 2006, Jeff Garzik wrote:
> Jeff Garzik wrote:
> >For libata, I think an ATA_FLAG_NO_FUA would be appropriate for
> >situations like this... assume FUA is supported in the controller, and
> >set a flag where it is not. Most chips will support FUA, either by
> >design or by sheer luck. The ones that do not support FUA are the
> >controllers that snoop the ATA command opcode, and internally choose the
> >protocol based on that opcode. For such hardware, unknown opcodes will
> >inevitably cause problems.
>
> This also begs the question... what controller was being used, when the
> single Maxtor device listed in the blacklist was added? Perhaps it was
> a problem with the controller, not the device.
Yeah which explains it a lot better as well... The FUA drive problem
never made much sense to me.
--
Jens Axboe
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 1:58 ` Jeff Garzik
2006-03-02 2:20 ` Eric D. Mudama
2006-03-02 7:22 ` Jens Axboe
@ 2006-03-02 15:59 ` Nicolas Mailhot
2006-03-02 16:37 ` Jeff Garzik
2 siblings, 1 reply; 27+ messages in thread
From: Nicolas Mailhot @ 2006-03-02 15:59 UTC (permalink / raw)
To: Jeff Garzik
Cc: Jens Axboe, Eric D. Mudama, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Le Jeu 2 mars 2006 02:58, Jeff Garzik a écrit :
> Jeff Garzik wrote:
>> For libata, I think an ATA_FLAG_NO_FUA would be appropriate for
>> situations like this... assume FUA is supported in the controller, and
>> set a flag where it is not. Most chips will support FUA, either by
>> design or by sheer luck. The ones that do not support FUA are the
>> controllers that snoop the ATA command opcode, and internally choose the
>> protocol based on that opcode. For such hardware, unknown opcodes will
>> inevitably cause problems.
>
> This also begs the question... what controller was being used, when the
> single Maxtor device listed in the blacklist was added? Perhaps it was
> a problem with the controller, not the device.
The controller in the bugzilla entry ie a SiI 3114.
It was a quick fix and I did expect more thorough investigation later
(probably 2.6.17 frame). Though it seems FUA-related problems are so
numerous FUA itself will be blacklisted for 2.6.16, so the limited
blacklist is no longer needed.
The thread leading to the blacklist is referenced in the bugzilla entry
--
Nicolas Mailhot
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: FUA and 311x (was Re: LibPATA code issues / 2.6.15.4)
2006-03-02 15:59 ` Nicolas Mailhot
@ 2006-03-02 16:37 ` Jeff Garzik
0 siblings, 0 replies; 27+ messages in thread
From: Jeff Garzik @ 2006-03-02 16:37 UTC (permalink / raw)
To: Nicolas Mailhot
Cc: Jens Axboe, Eric D. Mudama, Tejun Heo, Nicolas Mailhot, Mark Lord,
linux-ide, linux-kernel, Carlos Pardo
Nicolas Mailhot wrote:
> The controller in the bugzilla entry ie a SiI 3114.
> It was a quick fix and I did expect more thorough investigation later
> (probably 2.6.17 frame). Though it seems FUA-related problems are so
> numerous FUA itself will be blacklisted for 2.6.16, so the limited
> blacklist is no longer needed.
Well, we're looking for a long term solution :)
Disabling FUA by default in 2.6.16 is a temporary solution.
Jeff
^ permalink raw reply [flat|nested] 27+ messages in thread