From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2/6] sata_sil: kill bogus PCI ID 0x1095/0x0240 Date: Sun, 05 Mar 2006 16:51:03 +0900 Message-ID: <440A9867.2080202@gmail.com> References: <11415422321792-git-send-email-htejun@gmail.com> <440A963B.4080406@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from pproxy.gmail.com ([64.233.166.183]:61489 "EHLO pproxy.gmail.com") by vger.kernel.org with ESMTP id S1752090AbWCEHvH (ORCPT ); Sun, 5 Mar 2006 02:51:07 -0500 Received: by pproxy.gmail.com with SMTP id 57so540305pya for ; Sat, 04 Mar 2006 23:51:06 -0800 (PST) In-Reply-To: <440A963B.4080406@pobox.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Carlos.Pardo@siliconimage.com, linux-ide@vger.kernel.org Jeff Garzik wrote: > Tejun Heo wrote: > >> Silicon Image confirmed that 0x1095/0x0240 has never been used for >> 3112. Kill it. >> >> Signed-off-by: Tejun Heo >> Cc: Carlos Pardo >> >> --- >> >> drivers/scsi/sata_sil.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> 4c960f8b73294d01b9307ea6775304fc8556e550 >> diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c >> index 8cb662d..0d962a4 100644 >> --- a/drivers/scsi/sata_sil.c >> +++ b/drivers/scsi/sata_sil.c >> @@ -90,7 +90,6 @@ static void sil_post_set_mode (struct at >> >> static const struct pci_device_id sil_pci_tbl[] = { >> { 0x1095, 0x3112, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, >> - { 0x1095, 0x0240, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, >> { 0x1095, 0x3512, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3512 }, >> { 0x1095, 0x3114, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3114 }, >> { 0x1002, 0x436e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, > > > > These things just don't get made up out of thin air. I'm wonder if it > applies to a Silicon Image product running under a proprietary driver, > or OEM product with a bunch of SiI chips on it. In any case, I'm > reluctant to remove it. > Agreed. -- tejun