From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Jens Axboe <axboe@suse.de>, Mark Lord <liml@rtr.ca>
Subject: Re: Random libata notes
Date: Fri, 10 Mar 2006 23:20:45 +0900 [thread overview]
Message-ID: <44118B3D.9040103@gmail.com> (raw)
In-Reply-To: <4409CF74.7030808@garzik.org>
Jeff Garzik wrote:
> These are small TODO bits that I didn't want to forget... Patches welcome.
>
> 1) ATAPI edge case. Due to adding the padding s/g entry, we must adjust
> sg_tablesize to include ' - 1' for each driver
Isn't this handled by ata_scsi_slave_config()? If the attached device is
ATAPI, ata_scsi_slave_config() reduces max_hw_segments by 1. We'll need
to increment it back when detaching the device though.
>
> 2) ata_scsi_slave_config() hardcodes a call to
> blk_queue_max_phys_segments(, LIBATA_MAX_PRD), when the value passed
> should not be so limited on nice hardware like AHCI.
>
> 3) sata_mv: add back SCR_ERR clear?
> mv_scr_write(ap, SCR_ERROR, mv_scr_read(ap, SCR_ERROR));
>
> 4) sata_mv: set DMA mask
>
--
tejun
next prev parent reply other threads:[~2006-03-10 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-04 17:33 Random libata notes Jeff Garzik
2006-03-10 14:20 ` Tejun Heo [this message]
2006-03-10 14:33 ` Tejun Heo
2006-03-12 1:37 ` Jeff Garzik
2006-03-13 11:40 ` Tejun Heo
2006-03-12 1:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44118B3D.9040103@gmail.com \
--to=htejun@gmail.com \
--cc=axboe@suse.de \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).