From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: Random libata notes Date: Fri, 10 Mar 2006 23:20:45 +0900 Message-ID: <44118B3D.9040103@gmail.com> References: <4409CF74.7030808@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from zproxy.gmail.com ([64.233.162.203]:55379 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S1751305AbWCJOUv (ORCPT ); Fri, 10 Mar 2006 09:20:51 -0500 Received: by zproxy.gmail.com with SMTP id 13so772906nzn for ; Fri, 10 Mar 2006 06:20:51 -0800 (PST) In-Reply-To: <4409CF74.7030808@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: "linux-ide@vger.kernel.org" , Jens Axboe , Mark Lord Jeff Garzik wrote: > These are small TODO bits that I didn't want to forget... Patches welcome. > > 1) ATAPI edge case. Due to adding the padding s/g entry, we must adjust > sg_tablesize to include ' - 1' for each driver Isn't this handled by ata_scsi_slave_config()? If the attached device is ATAPI, ata_scsi_slave_config() reduces max_hw_segments by 1. We'll need to increment it back when detaching the device though. > > 2) ata_scsi_slave_config() hardcodes a call to > blk_queue_max_phys_segments(, LIBATA_MAX_PRD), when the value passed > should not be so limited on nice hardware like AHCI. > > 3) sata_mv: add back SCR_ERR clear? > mv_scr_write(ap, SCR_ERROR, mv_scr_read(ap, SCR_ERROR)); > > 4) sata_mv: set DMA mask > -- tejun