From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE Linux <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>, Doug Maxey <dwm@maxeymade.com>
Subject: [PATCH 5/5] libata-dev: Add back irq-pio patches, etc.
Date: Fri, 10 Mar 2006 23:55:59 +0800 [thread overview]
Message-ID: <4411A18F.8010009@tw.ibm.com> (raw)
In-Reply-To: <44119BC9.8080502@tw.ibm.com>
Add back irq-pio patches, etc.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
Changes:
- add back irq-pio patches removed in patch 3/5.
- ata_dev_revalidate() by Tejun
- remove redundant ap->hsm_task_state = HSM_ST_IDLE in ata_qc_timeout().
--- catchup3/drivers/scsi/libata-core.c 2006-03-10 18:04:35.000000000 +0800
+++ catchup4/drivers/scsi/libata-core.c 2006-03-10 18:11:56.000000000 +0800
@@ -1159,6 +1159,12 @@ static int ata_dev_configure(struct ata_
dev->cylinders, dev->heads, dev->sectors);
}
+ if (dev->id[59] & 0x100) {
+ dev->multi_count = dev->id[59] & 0xff;
+ DPRINTK("ata%u: dev %u multi count %u\n",
+ ap->id, device, dev->multi_count);
+ }
+
dev->cdb_len = 16;
}
@@ -1172,6 +1178,9 @@ static int ata_dev_configure(struct ata_
}
dev->cdb_len = (unsigned int) rc;
+ if (ata_id_cdb_intr(dev->id))
+ dev->flags |= ATA_DFLAG_CDB_INTR;
+
/* print device info to dmesg */
if (print_info)
printk(KERN_INFO "ata%u: dev %u ATAPI, max %s\n",
@@ -1618,6 +1627,12 @@ static void ata_dev_set_mode(struct ata_
idx = ofs + dev->xfer_shift;
WARN_ON(idx >= ARRAY_SIZE(xfer_mode_str));
+ if (ata_dev_revalidate(ap, dev, 0)) {
+ printk(KERN_ERR "ata%u: failed to revalidate after set "
+ "xfermode, disabled\n", ap->id);
+ ata_port_disable(ap);
+ }
+
DPRINTK("idx=%d xfer_shift=%u, xfer_mode=0x%x, base=0x%x, offset=%d\n",
idx, dev->xfer_shift, (int)dev->xfer_mode, (int)base, ofs);
@@ -3853,8 +3868,6 @@ static void ata_qc_timeout(struct ata_qu
printk(KERN_ERR "ata%u: command 0x%x timeout, stat 0x%x host_stat 0x%x\n",
ap->id, qc->tf.command, drv_stat, host_stat);
- ap->hsm_task_state = HSM_ST_IDLE;
-
/* complete taskfile transaction */
qc->err_mask |= AC_ERR_TIMEOUT;
break;
next prev parent reply other threads:[~2006-03-10 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 15:31 [PATCH 0/5] libata-dev: irq-pio minor fixes Albert Lee
2006-03-10 15:38 ` [PATCH 1/5] libata-dev: Add back missing dev->cdb_len = 16 Albert Lee
2006-03-10 15:43 ` [PATCH 2/5] libata-dev: Make dev->id dynamically allocated Albert Lee
2006-03-10 15:55 ` Albert Lee [this message]
2006-03-12 0:27 ` [PATCH 0/5] libata-dev: irq-pio minor fixes Jeff Garzik
2006-03-13 7:12 ` Albert Lee
2006-03-13 7:17 ` Tejun Heo
2006-03-13 7:20 ` [PATCH 0/3] libata-dev: irq-pio minor fixes (respin) Albert Lee
2006-03-13 7:25 ` [PATCH 1/3] libata-dev: Remove trailing whitespaces Albert Lee
2006-03-13 7:48 ` Jeff Garzik
2006-03-13 7:27 ` [PATCH 2/3] libata-dev: Fix merge problem with upstream Albert Lee
2006-03-13 7:28 ` [PATCH 3/3] libata-dev: Remove atapi_packet_task() Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4411A18F.8010009@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=dwm@maxeymade.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).