From: Jeff Garzik <jeff@garzik.org>
To: Mark Lord <lkml@rtr.ca>
Cc: Andrew Morton <akpm@osdl.org>,
sander@humilis.net, linux-ide@vger.kernel.org,
jgarzik@favonius.humilis.net
Subject: Re: sata_Re: sata_mv success on 2.6.16-rc6-mm2
Date: Sun, 19 Mar 2006 16:25:36 -0500 [thread overview]
Message-ID: <441DCC50.2000800@garzik.org> (raw)
In-Reply-To: <200603191613.37386.lkml@rtr.ca>
Mark Lord wrote:
> --- sata_mv.c.alignment 2006-03-19 15:14:29.000000000 -0500
> +++ sata_mv.c 2006-03-19 15:12:49.000000000 -0500
> @@ -1180,7 +1180,6 @@
> u32 hc_irq_cause;
> int shift, port, port0, hard_port, handled;
> unsigned int err_mask;
> - u8 ata_status = 0;
>
> if (hc == 0) {
> port0 = 0;
> @@ -1198,6 +1197,7 @@
> hc,relevant,hc_irq_cause);
>
> for (port = port0; port < port0 + MV_PORTS_PER_HC; port++) {
> + u8 ata_status = 0;
ACK, that's a bug (and fix) all right.
I'll wait and apply whatever cleaned-up patch arises out of this...
Jeff
next prev parent reply other threads:[~2006-03-19 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 21:13 sata_Re: sata_mv success on 2.6.16-rc6-mm2 Mark Lord
2006-03-19 21:25 ` Jeff Garzik [this message]
2006-03-21 10:26 ` Sander
2006-03-21 10:30 ` Andrew Morton
2006-03-21 13:49 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441DCC50.2000800@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=jgarzik@favonius.humilis.net \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=sander@humilis.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).