linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [git patch append] sata_mv fix
Date: Mon, 20 Mar 2006 19:57:57 -0500	[thread overview]
Message-ID: <441F4F95.4070203@garzik.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]


FWIW, I appended the attached changeset to the 'upstream-linus' branch 
of libata-dev.git (and also forwarded it to stable@kernel.org).

FWIW 2, except for fixes like the attached, 'upstream-linus' is a frozen 
branch, and normally isn't touched until you pull.  Development 
continues in the separate 'upstream' branch, which ensures there are no 
surprise csets when 'upstream-linus' is pulled.  'upstream-linus' is a 
branch that behaves like a tag. Most of the time.

	Jeff




[-- Attachment #2: libata.txt --]
[-- Type: text/plain, Size: 1132 bytes --]

commit cd85f6e2f58282186ad720fc18482be228f0b972
Author: Jeff Garzik <jeff@garzik.org>
Date:   Mon Mar 20 19:49:54 2006 -0500

    [libata] sata_mv: fix irq port status usage

    Interrupt handler did not properly initialize a variable on a per-port
    basis, leading to incorrect behavior on ports other than port 0.

    Bug caught and fixed by Mark Lord.

    Signed-off-by: Jeff Garzik <jeff@garzik.org>


cd85f6e2f58282186ad720fc18482be228f0b972
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index aceaf56..e561281 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -1353,7 +1353,6 @@ static void mv_host_intr(struct ata_host
 	u32 hc_irq_cause;
 	int shift, port, port0, hard_port, handled;
 	unsigned int err_mask;
-	u8 ata_status = 0;
 
 	if (hc == 0) {
 		port0 = 0;
@@ -1371,6 +1370,7 @@ static void mv_host_intr(struct ata_host
 		hc,relevant,hc_irq_cause);
 
 	for (port = port0; port < port0 + MV_PORTS_PER_HC; port++) {
+		u8 ata_status = 0;
 		ap = host_set->ports[port];
 		hard_port = port & MV_PORT_MASK;	/* range 0-3 */
 		handled = 0;	/* ensure ata_status is set if handled++ */

             reply	other threads:[~2006-03-21  0:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-21  0:57 Jeff Garzik [this message]
2006-03-21  5:00 ` [PATCH] 2.6.xx: sata_mv: another critical fix Mark Lord
2006-03-21 12:13   ` Sander
2006-03-21 13:51     ` Mark Lord
2006-03-21 15:37       ` Sander
2006-03-21 18:33         ` Linus Torvalds
2006-03-21 19:15           ` Sander
2006-03-21 19:22             ` Mark Lord
2006-03-21 19:35             ` Linus Torvalds
2006-03-21 20:44               ` Sander
2006-03-21 20:59                 ` Linus Torvalds
2006-03-21 21:09                   ` Jeff Garzik
2006-03-21 21:19                     ` Linus Torvalds
2006-03-21 21:37                       ` Jeff Garzik
2006-03-22  5:48                         ` Sander
2006-03-22  9:00                       ` Sander
2006-03-22 14:50                         ` Mark Lord
2006-03-22 17:09                           ` Sander
2006-03-22 17:53                             ` Eric D. Mudama
2006-03-22 18:01                               ` Sander
2006-03-22 17:55                             ` Mark Lord
2006-03-28  4:34                             ` Mark Lord
2006-05-03 12:16                               ` Sander
2006-05-03 12:42                                 ` Mark Lord
2006-05-03 13:32                                   ` Sander
2006-05-03 16:46                                     ` Mark Lord
2006-05-03 18:39                                       ` Sander
2006-03-22  2:12   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=441F4F95.4070203@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).