From: Brian King <brking@us.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 01/15] libata: Setup nbytes in ata_sg_init_one
Date: Wed, 22 Mar 2006 08:36:48 -0600 [thread overview]
Message-ID: <44216100.6050107@us.ibm.com> (raw)
In-Reply-To: <4420AC91.4070007@pobox.com>
Jeff Garzik wrote:
> Brian King wrote:
>> Setup nbytes in ata_sg_init_one to the total transfer length
>> of the command.
>>
>> Signed-off-by: Brian King <brking@us.ibm.com>
>> ---
>>
>> libata-dev-bjking1/drivers/scsi/libata-core.c | 1 +
>> 1 files changed, 1 insertion(+)
>>
>> diff -puN drivers/scsi/libata-core.c~libata_setup_nbytes drivers/scsi/libata-core.c
>> --- libata-dev/drivers/scsi/libata-core.c~libata_setup_nbytes 2006-03-17 15:35:26.000000000 -0600
>> +++ libata-dev-bjking1/drivers/scsi/libata-core.c 2006-03-17 15:35:26.000000000 -0600
>> @@ -2887,6 +2887,7 @@ void ata_sg_init_one(struct ata_queued_c
>> qc->n_elem = 1;
>> qc->orig_n_elem = 1;
>> qc->buf_virt = buf;
>> + qc->nbytes = buflen;
>
> Why?
>
> This is largely an internal variable used by the ATAPI code.
The ipr driver needs to know the total transfer length of the command
in bytes to setup the command to the adapter properly, since the adapter
firmware interface requires it. I didn't see anywhere else to get this
information, the only other option would be to compute it based on the
scatterlist.
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2006-03-22 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 23:03 [PATCH 01/15] libata: Setup nbytes in ata_sg_init_one Brian King
2006-03-22 1:46 ` Jeff Garzik
2006-03-22 14:36 ` Brian King [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-06 15:42 [patch " brking
2006-02-09 7:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44216100.6050107@us.ibm.com \
--to=brking@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).