From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: IDE Linux <linux-ide@vger.kernel.org>, Doug Maxey <dwm@maxeymade.com>
Subject: [PATCH 1/2] libata-dev: irq-pio minor fixes
Date: Thu, 23 Mar 2006 16:04:12 +0800 [thread overview]
Message-ID: <4422567C.5000008@tw.ibm.com> (raw)
In-Reply-To: <311601c90603210943v132a369aya443a073c11ee2bf@mail.gmail.com>
irq-pio minor fixes for printk() and comments.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
Patch against previous irq-pio snapshot.
The current irq-pio branch (949ec2c8e6b7b89179b85baf6309c009e1a1b951)
looks strange. Maybe it is under refresh.
--- irq-pio-00/drivers/scsi/libata-core.c 2006-03-23 11:10:58.000000000 +0800
+++ irq-pio-deverr0/drivers/scsi/libata-core.c 2006-03-23 14:56:03.000000000 +0800
@@ -1283,7 +1283,7 @@ static int ata_dev_configure(struct ata_
if (dev->id[59] & 0x100) {
dev->multi_count = dev->id[59] & 0xff;
DPRINTK("ata%u: dev %u multi count %u\n",
- ap->id, device, dev->multi_count);
+ ap->id, dev->devno, dev->multi_count);
}
dev->cdb_len = 16;
@@ -3562,6 +3562,9 @@ static int ata_hsm_move(struct ata_port
}
fsm_start:
+ DPRINTK("ata%u: protocol %d task_state %d (dev_stat 0x%X)\n",
+ ap->id, qc->tf.protocol, ap->hsm_task_state, status);
+
switch (ap->hsm_task_state) {
case HSM_ST_FIRST:
/* Send first data block or PACKET CDB */
@@ -3688,6 +3691,7 @@ fsm_start:
ap->hsm_task_state = HSM_ST_IDLE;
+ /* complete taskfile transaction */
if (in_wq)
ata_poll_qc_complete(qc);
else
@@ -4441,9 +4445,6 @@ inline unsigned int ata_host_intr (struc
if (unlikely(status & ATA_BUSY))
goto idle_irq;
- DPRINTK("ata%u: protocol %d task_state %d (dev_stat 0x%X)\n",
- ap->id, qc->tf.protocol, ap->hsm_task_state, status);
-
/* ack bmdma irq events */
ap->ops->irq_clear(ap);
next prev parent reply other threads:[~2006-03-23 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-21 11:39 [PATCH/RFC] libata-dev: handle ERR=1 DRQ=1 Albert Lee
2006-03-21 17:35 ` Jeff Garzik
2006-03-21 17:43 ` Eric D. Mudama
2006-03-23 8:04 ` Albert Lee [this message]
2006-03-23 8:18 ` [PATCH 1/2] libata-dev: irq-pio minor fixes Jeff Garzik
2006-03-24 17:28 ` Jeff Garzik
2006-03-25 10:07 ` [PATCH 1/3] libata-dev: irq-pio minor fixes (respin) Albert Lee
2006-03-29 22:22 ` Jeff Garzik
2006-03-25 10:11 ` [PATCH 2/3] libata-dev: fix the device err check sequence (respin) Albert Lee
2006-03-25 10:18 ` [PATCH 3/3] libata-dev: wait idle after reading the last data block Albert Lee
2006-03-23 8:26 ` [PATCH/RFC 2/2] libata-dev: fix the device err check sequence Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4422567C.5000008@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=albertl@mail.com \
--cc=dwm@maxeymade.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).