From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: add FIXME above ata_dev_xfermask()
Date: Fri, 24 Mar 2006 23:09:31 -0500 [thread overview]
Message-ID: <4424C27B.1090000@pobox.com> (raw)
In-Reply-To: <20060325021407.GF5288@htj.dyndns.org>
Tejun Heo wrote:
> Add FIXME above ata_dev_xfermask noting that the current
> implementation limits all transfer modes to the fastest of the slowest
> device on a port which isn't necessary.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> index 0aff888..e4bd673 100644
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -2634,6 +2634,10 @@ static int ata_dma_blacklisted(const str
> * known limits including host controller limits, device
> * blacklist, etc...
> *
> + * FIXME: The current implementation limits all transfer modes to
> + * the fastest of the lowested device on the port. This is not
> + * required on most controllers.
applied, though git complained about...
[jgarzik@pretzel libata-dev]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'libata: add FIXME above ata_dev_xfermask()'
Adds trailing whitespace.
.dotest/patch:11: * required on most controllers.
warning: 1 line adds trailing whitespaces.
Wrote tree 0fc6b51c6ddfb5d3f759bb88a34d8003386a50d7
Committed: 600511e86babe3727264a0883a3a264f6fb6caf5
next prev parent reply other threads:[~2006-03-25 4:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 5:07 [PATCHSET] libata: implement per-dev xfer masks, take#2 Tejun Heo
2006-03-24 5:07 ` [PATCH 1/3] libata: implement ata_unpack_xfermask() Tejun Heo
2006-03-24 5:07 ` [PATCH 3/3] libata: make per-dev transfer mode limits per-dev Tejun Heo
2006-03-24 5:07 ` [PATCH 2/3] libata: add per-dev pio/mwdma/udma_mask Tejun Heo
2006-03-24 14:30 ` Jeff Garzik
2006-03-25 2:14 ` [PATCH] libata: add FIXME above ata_dev_xfermask() Tejun Heo
2006-03-25 4:09 ` Jeff Garzik [this message]
2006-03-25 5:28 ` [PATCH] libata: kill trailing whitespace Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4424C27B.1090000@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).