From: Jeff Garzik <jgarzik@pobox.com>
To: albertl@mail.com
Cc: IDE Linux <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 1/1] libata: use AC_ERR_TIMEOUT err_mask for time out
Date: Fri, 31 Mar 2006 10:06:09 -0500 [thread overview]
Message-ID: <442D4561.60705@pobox.com> (raw)
In-Reply-To: <442CC185.3060200@tw.ibm.com>
Albert Lee wrote:
> Use AC_ERR_TIMEOUT err_mask for time out,
> instead of generating err_mask from drv_stat.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
> ---
> This patch was accepted in irq-pio before.
>
> Patch against upstream (8b316a3973f05e572b4edeeda9072987f6bbaa44).
> For your review, thanks.
>
> Albert
>
> --- upstream0/drivers/scsi/libata-core.c 2006-03-31 13:33:15.000000000 +0800
> +++ upstream1/drivers/scsi/libata-core.c 2006-03-31 13:34:59.000000000 +0800
> @@ -3827,7 +3827,7 @@ static void ata_qc_timeout(struct ata_qu
> ap->id, qc->tf.command, drv_stat, host_stat);
>
> /* complete taskfile transaction */
> - qc->err_mask |= ac_err_mask(drv_stat);
> + qc->err_mask |= AC_ERR_TIMEOUT;
The intention here is to catch missed interrupts; due to flaky hardware
or buggy drivers, we may miss an interrupt, but still be able to
complete the qc in the timeout handler. Thus, if the ac_err_mask()
indicates a BSY or DRQ or DF is asserted, it will indicate an error,
otherwise not.
So, NAK, and we should fix irq-pio for this as well...
Jeff
next prev parent reply other threads:[~2006-03-31 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 5:43 [PATCH 1/1] libata: use AC_ERR_TIMEOUT err_mask for time out Albert Lee
2006-03-31 15:06 ` Jeff Garzik [this message]
2006-03-31 18:14 ` Tejun Heo
2006-03-31 18:17 ` Tejun Heo
2006-04-01 0:34 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442D4561.60705@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertl@mail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).