linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ata_piix: fix ich6/m_map_db
@ 2006-03-31 11:01 Tejun Heo
  2006-03-31 15:15 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-03-31 11:01 UTC (permalink / raw)
  To: Jeff Garzik, linux-ide

MAP tables of ich6 and ich6m are wrong.  Depending on port usage,
ata_piix may fail to initialize attached devices.

Signed-off-by: Tejun Heo <htejun@gmail.com>

---

Jeff, this one is critical.  I compiled all port allocation tables
correctly on my notebook, yet I succeeded to screw up.  Dang.  Sorry
about the trouble.

 ata_piix.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: work/drivers/scsi/ata_piix.c
===================================================================
--- work.orig/drivers/scsi/ata_piix.c	2006-03-31 19:50:49.000000000 +0900
+++ work/drivers/scsi/ata_piix.c	2006-03-31 19:54:09.000000000 +0900
@@ -301,7 +301,7 @@ static struct piix_map_db ich6_map_db = 
 	.mask = 0x3,
 	.map = {
 		/* PM   PS   SM   SS       MAP */
-		{  P0,  P1,  P2,  P3 }, /* 00b */
+		{  P0,  P2,  P1,  P3 }, /* 00b */
 		{ IDE, IDE,  P1,  P3 }, /* 01b */
 		{  P0,  P2, IDE, IDE }, /* 10b */
 		{  RV,  RV,  RV,  RV },
@@ -312,7 +312,7 @@ static struct piix_map_db ich6m_map_db =
 	.mask = 0x3,
 	.map = {
 		/* PM   PS   SM   SS       MAP */
-		{  P0,  P1,  P2,  P3 }, /* 00b */
+		{  P0,  P2,  RV,  RV }, /* 00b */
 		{  RV,  RV,  RV,  RV },
 		{  P0,  P2, IDE, IDE }, /* 10b */
 		{  RV,  RV,  RV,  RV },

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-03-31 15:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-31 11:01 [PATCH] ata_piix: fix ich6/m_map_db Tejun Heo
2006-03-31 15:15 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).