From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: fix ata_qc_issue failure path
Date: Fri, 31 Mar 2006 10:16:24 -0500 [thread overview]
Message-ID: <442D47C8.8030609@pobox.com> (raw)
In-Reply-To: <20060331113647.GD13172@htj.dyndns.org>
Tejun Heo wrote:
> On sg_err failure path, ata_qc_issue() doesn't mark the qc active
> before returning. This triggers WARN_ON() in __ata_qc_complete() when
> the qc gets completed. This patch moves ap->active_tag and
> QCFLAG_ACTIVE setting to the top of the function.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied 1-2, but two comments:
* this patch widens the race window for the remaining unlocked uses of
ATA_QCFLAG_ACTIVE
* in the current code, its questionable whether ATA_QCFLAG_ACTIVE has
much value. The flag may have more value after your EH work, but its
not terribly important in the current #upstream.
Jeff
next prev parent reply other threads:[~2006-03-31 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 11:36 [PATCH 1/2] libata: fix ata_qc_issue failure path Tejun Heo
2006-03-31 11:41 ` [PATCH 2/2] libata: make ata_qc_issue complete failed qcs Tejun Heo
2006-03-31 15:16 ` Jeff Garzik [this message]
2006-03-31 18:41 ` [PATCH 1/2] libata: fix ata_qc_issue failure path Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442D47C8.8030609@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).