* [PATCH] libata: fix ata_xfer_tbl termination
@ 2006-03-31 13:48 Tejun Heo
2006-03-31 15:16 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-03-31 13:48 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
ata_xfer_tbl is terminated by entry with -1 as ->shift. However,
->shift was unsigned int making the termination condition bogus. This
patch converts ->shift and ->bits to int.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Index: work/drivers/scsi/libata-core.c
===================================================================
--- work.orig/drivers/scsi/libata-core.c 2006-03-31 22:45:13.000000000 +0900
+++ work/drivers/scsi/libata-core.c 2006-03-31 22:45:57.000000000 +0900
@@ -278,7 +278,7 @@ static void ata_unpack_xfermask(unsigned
}
static const struct ata_xfer_ent {
- unsigned int shift, bits;
+ int shift, bits;
u8 base;
} ata_xfer_tbl[] = {
{ ATA_SHIFT_PIO, ATA_BITS_PIO, XFER_PIO_0 },
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: fix ata_xfer_tbl termination
2006-03-31 13:48 [PATCH] libata: fix ata_xfer_tbl termination Tejun Heo
@ 2006-03-31 15:16 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-03-31 15:16 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> ata_xfer_tbl is terminated by entry with -1 as ->shift. However,
> ->shift was unsigned int making the termination condition bogus. This
> patch converts ->shift and ->bits to int.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-31 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-31 13:48 [PATCH] libata: fix ata_xfer_tbl termination Tejun Heo
2006-03-31 15:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).