Re: [PATCH] move ->eh_strategy_handler to the transport class

Re: [PATCH] move ->eh_strategy_handler to the transport class

[Jeff Garzik]

Christoph Hellwig wrote:
> Overriding the whole EH code is a per-transport, not per-host thing.
> Move ->eh_strategy_handler to the transport class, same as
> ->eh_timed_out.
> 
> Downside is that scsi_host_alloc can't check for the total lack of EH
> anymore, but the transition period from old EH where we needed it is
> long gone already.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks OK to me.  I agree the transport the better place for 
eh_strategy_handler.

I would prefer to merge it through the libata-dev queue, since -- as a 
glance through the recent kernel changelog shows -- Tejun Heo has been 
ripping through this part of libata as well.

	Jeff

Re: [PATCH] move ->eh_strategy_handler to the transport class

[James Bottomley]

On Sat, 2006-04-01 at 13:10 -0500, Jeff Garzik wrote:
> I would prefer to merge it through the libata-dev queue, since -- as a 
> glance through the recent kernel changelog shows -- Tejun Heo has been 
> ripping through this part of libata as well.

I'm afraid we can't do that since we have the sas class to convert as
well ... what I could do is take it through a separate tree and pull
that into scsi-misc and you can pull it into libata.  That will
(hopefully) ensure we both get it right.

James

Re: [PATCH] move ->eh_strategy_handler to the transport class

[Jeff Garzik]

James Bottomley wrote:
> On Sat, 2006-04-01 at 13:10 -0500, Jeff Garzik wrote:
>> I would prefer to merge it through the libata-dev queue, since -- as a 
>> glance through the recent kernel changelog shows -- Tejun Heo has been 
>> ripping through this part of libata as well.
> 
> I'm afraid we can't do that since we have the sas class to convert as
> well ... what I could do is take it through a separate tree and pull
> that into scsi-misc and you can pull it into libata.  That will
> (hopefully) ensure we both get it right.

Works for me...

Thanks,

	Jeff

Re: [PATCH] move ->eh_strategy_handler to the transport class

[Jeff Garzik]

James Bottomley wrote:
> On Sat, 2006-04-01 at 13:10 -0500, Jeff Garzik wrote:
>> I would prefer to merge it through the libata-dev queue, since -- as a 
>> glance through the recent kernel changelog shows -- Tejun Heo has been 
>> ripping through this part of libata as well.
> 
> I'm afraid we can't do that since we have the sas class to convert as
> well ... what I could do is take it through a separate tree and pull
> that into scsi-misc and you can pull it into libata.  That will
> (hopefully) ensure we both get it right.

Grumble!!  The following is why I wanted to merge it through libata:

Linus writes:
> Ok, 
>  it's two weeks since 2.6.16, and the merge window is closed.

This is precisely why I grumbled last time libata and scsi-misc needed 
some synchronization.  scsi-misc just isn't pushed as often as libata, 
and I'm stuck behind a slow-moving car.

I think Christoph's patch can still go into 2.6.17-rc I think.  I'll get 
that separate repository together if I don't hear from you soon.

	Jeff