From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH/RFC] libata-dev: handle DRQ=1 ERR=1 (revised)
Date: Sat, 01 Apr 2006 14:29:43 -0500 [thread overview]
Message-ID: <442ED4A7.1050509@garzik.org> (raw)
In-Reply-To: <442E4A23.8000409@tw.ibm.com>
Albert Lee wrote:
> Handle DRQ=1 ERR=1 situation. Revised according to what IDE try_to_flush_leftover_data() does.
>
> Changes:
> - For ATA PIO writes and ATAPI devices, just stop the HSM and let EH handle it.
> - For ATA PIO reads, read only one block of junk data and then let EH handle it.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
> ---
> Thanks for the IDE try_to_flush_leftover_data() pointer.
> The difference between IDE and irq-pio (before this patch):
> 1. IDE only does the data transfer for PIO reads.
> For PIO writes and ATAPI, it just stops and abort/reset.
> 2. For PIO reads, only one block of data is transferred. EH then takes over if DRQ is still set after that.
> The behavior of irq-pio before this patch is: let HSM go on, until the device set DRQ=0 or all data read.
>
> Te IDE behavior looks safer. (When the device is in bad status, we really should not
> write any data to it.)
>
> Patch against irq-pio branch (08a556db919f67e1e4d33ae8d40f7222da34d994).
> For your review, thanks.
applied
prev parent reply other threads:[~2006-04-01 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 0:31 On the subject of DRQ and EH Jeff Garzik
2006-04-01 9:13 ` Albert Lee
2006-04-01 9:38 ` [PATCH/RFC] libata-dev: handle DRQ=1 ERR=1 (revised) Albert Lee
2006-04-01 19:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442ED4A7.1050509@garzik.org \
--to=jeff@garzik.org \
--cc=albertl@mail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).