From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, albertcc@tw.ibm.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/7] libata: improve ata_bus_probe()
Date: Sun, 02 Apr 2006 06:47:23 -0400 [thread overview]
Message-ID: <442FABBB.80203@pobox.com> (raw)
In-Reply-To: <11439680863401-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> +
> + fail:
> + switch (rc) {
> + case -EINVAL:
> + case -ENODEV:
> + tries[dev->devno] = 0;
> + break;
> + case -EIO:
> + ata_down_sata_spd_limit(ap);
I starting to think that separating ata_down_sata_spd_limit() from the
actual phy programming is a bad idea.
However, I'm not going to NAK it just yet, we'll see where this goes.
Jeff
next prev parent reply other threads:[~2006-04-02 10:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-02 8:54 [PATCHSET] libata: improve ata_bus_probe failure handling, take 2 Tejun Heo
2006-04-02 8:54 ` [PATCH 2/7] libata: implement ap->sata_spd_limit and helpers Tejun Heo
2006-04-02 10:43 ` Jeff Garzik
2006-04-02 11:04 ` Tejun Heo
2006-04-02 11:18 ` Jeff Garzik
2006-04-02 11:53 ` Tejun Heo
2006-04-02 8:54 ` [PATCH 5/7] libata: implement ata_down_xfermask_limit() Tejun Heo
2006-04-02 8:54 ` [PATCH 1/7] libata: implement ata_dev_absent() Tejun Heo
2006-04-02 8:54 ` [PATCH 4/7] libata: add 5s sleep between resets Tejun Heo
2006-04-02 11:55 ` Tejun Heo
2006-04-02 8:54 ` [PATCH 6/7] libata: improve ata_bus_probe() Tejun Heo
2006-04-02 10:47 ` Jeff Garzik [this message]
2006-04-02 8:54 ` [PATCH 3/7] libata: use SATA speed down in ata_drive_probe_reset() Tejun Heo
2006-04-02 8:54 ` [PATCH 7/7] libata: consider disabled devices in ata_dev_xfermask() Tejun Heo
2006-04-02 14:35 ` [PATCHSET] libata: improve ata_bus_probe failure handling, take 2 Jeff Garzik
2006-04-03 9:37 ` Albert Lee
2006-04-03 10:38 ` Jeff Garzik
2006-04-03 14:37 ` Greg Freemyer
2006-04-03 16:20 ` Jeff Garzik
2006-04-04 13:02 ` Greg Freemyer
2006-04-04 13:11 ` Jeff Garzik
2006-04-04 5:02 ` Albert Lee
2006-04-03 9:43 ` [PATCH] libata-dev: irq-pio minor fix Albert Lee
2006-04-04 12:42 ` Jeff Garzik
2006-04-03 10:31 ` [PATCH] libata-dev: irq-pio minor fix 2 Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442FABBB.80203@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).