* [PATCH] libata: print SControl in SATA link status info message
@ 2006-04-02 15:09 Tejun Heo
2006-04-02 15:38 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-04-02 15:09 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
Now that libata mangles with SControl, it's helpful to print out
SControl in link status message. Add it.
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 8beba3c..966be30 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1503,20 +1503,23 @@ void ata_port_probe(struct ata_port *ap)
*/
static void sata_print_link_status(struct ata_port *ap)
{
- u32 sstatus, tmp;
+ u32 sstatus, scontrol, tmp;
if (!ap->ops->scr_read)
return;
sstatus = scr_read(ap, SCR_STATUS);
+ scontrol = scr_read(ap, SCR_CONTROL);
if (sata_dev_present(ap)) {
tmp = (sstatus >> 4) & 0xf;
- printk(KERN_INFO "ata%u: SATA link up %s (SStatus %X)\n",
- ap->id, sata_spd_string(tmp), sstatus);
+ printk(KERN_INFO
+ "ata%u: SATA link up %s (SStatus %X SControl %X)\n",
+ ap->id, sata_spd_string(tmp), sstatus, scontrol);
} else {
- printk(KERN_INFO "ata%u: SATA link down (SStatus %X)\n",
- ap->id, sstatus);
+ printk(KERN_INFO
+ "ata%u: SATA link down (SStatus %X SControl %X)\n",
+ ap->id, sstatus, scontrol);
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: print SControl in SATA link status info message
2006-04-02 15:09 [PATCH] libata: print SControl in SATA link status info message Tejun Heo
@ 2006-04-02 15:38 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-04-02 15:38 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> Now that libata mangles with SControl, it's helpful to print out
> SControl in link status message. Add it.
Applied, please don't forget signed-off-by.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-02 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-02 15:09 [PATCH] libata: print SControl in SATA link status info message Tejun Heo
2006-04-02 15:38 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).