From: Mark Lord <lkml@rtr.ca>
To: Dan Aloni <da-x@monatomic.org>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: sata_mv: module reloading doesn't work
Date: Sun, 02 Apr 2006 12:21:34 -0400 [thread overview]
Message-ID: <442FFA0E.4070101@rtr.ca> (raw)
In-Reply-To: <20060402161449.GA21822@localdomain>
Dan Aloni wrote:
> On Sun, Apr 02, 2006 at 12:05:46PM -0400, Mark Lord wrote:
>
>> What kernel? Any patches applied to sata_mv.c ??
>
> 2.6.16 + ncq branch. sata_mv.c was modified by me - I'll retry
> with a cleaner configuration, sorry.
The NCQ stuff is *unsafe* with the existing sata_mv.c,
as there are known (to me, at least) bugs that prevent it
from working reliably after the first I/O error of any kind.
The 2.6.16.1 branch is slightly better,
and there is also the "three bug fixes" update
that's in upstream to help things further.
With all of those fixes, the module loads/unloads/reloads fine for me.
If you want to use NCQ more safely, then you'll need to modify
the mv_start_dma() routine to reinitialize the queue pointers
each time, as they can get out of sync after an error.
There are still other bugs to be worked out and fixed, though.
I'll have a patch or two this week for the ones I know about.
Cheers
next prev parent reply other threads:[~2006-04-02 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-02 15:56 sata_mv: module reloading doesn't work Dan Aloni
2006-04-02 16:05 ` Mark Lord
2006-04-02 16:14 ` Dan Aloni
2006-04-02 16:21 ` Mark Lord [this message]
2006-04-02 19:05 ` Dan Aloni
2006-04-02 17:59 ` Eric D. Mudama
2006-04-02 22:44 ` Dan Aloni
2006-04-03 21:57 ` Dan Aloni
2006-04-04 2:47 ` Mark Lord
2006-04-04 5:24 ` Dan Aloni
2006-04-04 6:08 ` Dan Aloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442FFA0E.4070101@rtr.ca \
--to=lkml@rtr.ca \
--cc=da-x@monatomic.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).