From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: linux-ide@vger.kernel.org,
Jonathan Benson <airbatica@verizon.net>,
Tejun Heo <htejun@gmail.com>,
Carlos Pardo <Carlos.Pardo@siliconimage.com>,
Doug Maxey <dwm@maxeymade.com>
Subject: Re: [PATCH/RFC] libata: turn on the ATAPI DMADIR support per word 62 (revised)
Date: Fri, 07 Apr 2006 13:54:56 -0400 [thread overview]
Message-ID: <4436A770.70107@garzik.org> (raw)
In-Reply-To: <4436431C.8070800@tw.ibm.com>
Albert Lee wrote:
> Turn on the ATAPI DMADIR support if word 62 indicates it.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
> ---
> (Revised to add mwdma/udma mask of word 62 per Jeff's comments.
> Need more testing once I get the SiI 3811, etc.)
>
> ATAPI DMADIR follow-up patch to turn on the DMADIR support automatically
> by checking identify device word 62. (Thanks for Jeff and Tejun's pointer.)
>
> According to Jonathan's test result, SiI 3611 (the current known bridge that
> requires the ATAPI DMADIR support) doesn't implement word 62. So, the
> atapi_dmadir parameter is preserved to enable the DMA DIR support manually as
> work around.
>
> Patch against upstream (c2a6585296009379e0f4eff39cdcb108b457ebf2).
> For your review, thanks.
I ACK the patch, though like I said, I would like to see this tested
first with some compliant devices.
Jeff
next prev parent reply other threads:[~2006-04-07 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 2:01 libata machine check on Alpha Jonathan Benson
2006-04-07 6:18 ` Albert Lee
2006-04-07 6:39 ` [PATCH/RFC] libata: turn on the ATAPI DMA DIR support per word 62 Albert Lee
2006-04-07 6:47 ` Jeff Garzik
2006-04-07 10:21 ` Albert Lee
2006-04-07 10:46 ` [PATCH/RFC] libata: turn on the ATAPI DMADIR support per word 62 (revised) Albert Lee
2006-04-07 17:54 ` Jeff Garzik [this message]
2006-04-18 4:34 ` Albert Lee
2006-04-20 22:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4436A770.70107@garzik.org \
--to=jeff@garzik.org \
--cc=Carlos.Pardo@siliconimage.com \
--cc=airbatica@verizon.net \
--cc=albertl@mail.com \
--cc=dwm@maxeymade.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).