From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, axboe@suse.de, albertcc@tw.ibm.com,
lkosewsk@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/3] libata: prefix sata register print outs with 0x
Date: Tue, 11 Apr 2006 13:24:04 -0400 [thread overview]
Message-ID: <443BE634.7060406@pobox.com> (raw)
In-Reply-To: <1144761989558-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Prefix SStatus and SControl values with 0x as they are hex.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
NAK, libata always prints out device id, register, etc. values in hex.
Basically anything other than things like sectors or bytes is printed in
hex. Therefore, the "0x" is largely redundant.
The prefix/base is implicit in the context.
Jeff
next prev parent reply other threads:[~2006-04-11 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 13:26 [PATCHSET 3/9] misc ata_bus_probe() updates Tejun Heo
2006-04-11 13:26 ` [PATCH 1/3] libata: disable failed devices only once in ata_bus_probe() Tejun Heo
2006-04-11 17:22 ` Jeff Garzik
2006-04-11 13:26 ` [PATCH 3/3] libata: prefix sata register print outs with 0x Tejun Heo
2006-04-11 17:24 ` Jeff Garzik [this message]
2006-04-12 1:20 ` Tejun Heo
2006-04-11 13:26 ` [PATCH 2/3] libata: cosmetic update to ata_bus_probe() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443BE634.7060406@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).