From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, axboe@suse.de, albertcc@tw.ibm.com,
lkosewsk@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 06/13] sata_sil24: implement loss of completion interrupt on PCI-X errta fix
Date: Tue, 11 Apr 2006 13:27:21 -0400 [thread overview]
Message-ID: <443BE6F9.8020403@pobox.com> (raw)
In-Reply-To: <1144762339715-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> @@ -738,6 +740,10 @@ static inline void sil24_host_intr(struc
> slot_stat = readl(port + PORT_SLOT_STAT);
> if (!(slot_stat & HOST_SSTAT_ATTN)) {
> struct sil24_port_priv *pp = ap->private_data;
> +
> + if (ap->flags & SIL24_FLAG_PCIX_IRQ_WOC)
> + writel(PORT_IRQ_COMPLETE, port + PORT_IRQ_STAT);
> +
This looks racy. Since the interrupt is usually level-triggered,
doesn't this introduce the possibility of losing interrupt events?
Jeff
next prev parent reply other threads:[~2006-04-11 17:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 13:32 [PATCHSET 4/9] sata_sil24 fixes, errata workaround and reset updates, take 3 Tejun Heo
2006-04-11 13:32 ` [PATCH 01/13] libata: export ata_set_sata_spd() Tejun Heo
2006-04-11 17:32 ` Jeff Garzik
2006-04-11 13:32 ` [PATCH 04/13] sata_sil24: add more constants Tejun Heo
2006-04-11 13:32 ` [PATCH 03/13] sata_sil24: rename PORT_IRQ_SDB_FIS to PORT_IRQ_SDB_NOTIFY Tejun Heo
2006-04-11 13:32 ` [PATCH 02/13] sata_sil24: typo fix Tejun Heo
2006-04-11 13:32 ` [PATCH 05/13] sata_sil24: consolidate host flags into SIL24_COMMON_FLAGS Tejun Heo
2006-04-11 13:32 ` [PATCH 07/13] sata_sil24: implement sil24_init_port() Tejun Heo
2006-04-11 13:32 ` [PATCH 13/13] sata_sil24: enable 64bit Tejun Heo
2006-04-11 13:32 ` [PATCH 08/13] sata_sil24: put port into known state before softresetting Tejun Heo
2006-04-11 17:29 ` Jeff Garzik
2006-04-11 13:32 ` [PATCH 12/13] sata_sil24: fix on-memory structure byteorder Tejun Heo
2006-04-11 13:32 ` [PATCH 10/13] sata_sil24: reimplement hardreset Tejun Heo
2006-04-11 13:32 ` [PATCH 11/13] sata_sil24: don't do hardreset during driver initialization Tejun Heo
2006-04-11 13:32 ` [PATCH 06/13] sata_sil24: implement loss of completion interrupt on PCI-X errta fix Tejun Heo
2006-04-11 17:27 ` Jeff Garzik [this message]
2006-04-12 1:13 ` Tejun Heo
2006-04-11 13:32 ` [PATCH 09/13] sata_sil24: kill 10ms sleep in softreset Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2006-04-07 8:16 [PATCHSET] sata_sil24: fixes, errata workaround and reset updates, take 2 Tejun Heo
2006-04-07 8:16 ` [PATCH 06/13] sata_sil24: implement loss of completion interrupt on PCI-X errta fix Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443BE6F9.8020403@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).