Re: [PATCH 1/2] SCSI: implement scsi_eh_schedule_cmd()

[Jeff Garzik <jgarzik@pobox.com>]

Tejun Heo wrote:
> This patch implements scsi_eh_schedule_cmd() which provides a way to
> directly invoke SCSI EH from drivers implementing
> ->eh_strategy_handler.  Combined with scsi_eh_flush_done_q(), this
> gives such drivers complete control over when and how to invoke EH and
> handle failed commands.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> ---
> 
>  drivers/scsi/scsi_error.c |   24 ++++++++++++++++++++++++
>  include/scsi/scsi_eh.h    |    1 +
>  2 files changed, 25 insertions(+), 0 deletions(-)
> 
> caaed524eab41fab88be717d06627bd50cf66ee2
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 5f0fdfb..c314095 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -90,6 +90,30 @@ int scsi_eh_scmd_add(struct scsi_cmnd *s
>  }
>  
>  /**
> + * scsi_eh_schedule_cmd - schedule scsi cmd for error handling.
> + * @scmd:	scmd to run eh on.
> + *
> + * Description:
> + *	This function is used by LLDDs which don't use standard SCSI
> + *	EH to schedule scmd for EH.
> + *
> + * Return value:
> + *	0 on failure.
> + **/
> +int scsi_eh_schedule_cmd(struct scsi_cmnd *scmd)
> +{
> +	struct Scsi_Host *shost = scmd->device->host;
> +
> +	WARN_ON(!shost->hostt->eh_strategy_handler);
> +
> +	if (!scsi_delete_timer(scmd))
> +		return 0;	/* timeout won */
> +
> +	return scsi_eh_scmd_add(scmd, 0);
> +}
> +EXPORT_SYMBOL_GPL(scsi_eh_schedule_cmd);


ACK, though this patch makes me think that there are some non-libata 
pieces of code that could use this function.

Unfortunately for libata, we are stuck waiting on linux-scsi people to 
return and give their opinion.  If nobody complains, I'll apply it, if 
it doesn't appear in scsi-misc-2.6 sometime vaguely soon.

	Jeff