From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: hch@lst.de, James.Bottomley@SteelEye.com,
alan@lxorguk.ukuu.org.uk, albertcc@tw.ibm.com,
arjan@infradead.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] SCSI: implement scsi_eh_schedule_host()
Date: Tue, 11 Apr 2006 13:43:15 -0400 [thread overview]
Message-ID: <443BEAB3.9050704@pobox.com> (raw)
In-Reply-To: <20060402160646.GN13172@htj.dyndns.org>
Tejun Heo wrote:
> This patch implements scsi_eh_schedule_host() which provides a way to
> directly invoke SCSI EH without SCSI command from drivers implementing
> ->eh_strategy_handler. This allows such drivers to use EH to handle
> exception conditions which are not associated with particular SCSI
> command.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> ---
>
> Jeff, I think using separate variable (->host_eh_scheduled) is the
> simplest way to implement this. Adding more semantics to ->host_busy
> and failed doesn't sound very attractive to me.
ACK, I reviewed the existing uses of host_busy and host_error (not too
many), and this should be OK.
However, I continue to be nervous being in the error handler when
host_busy and host_error are zero.
Jeff
next prev parent reply other threads:[~2006-04-11 17:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 10:38 [PATCH] SCSI: implement scsi_eh_schedule() Tejun Heo
2006-04-01 20:14 ` Jeff Garzik
2006-04-02 1:15 ` Tejun Heo
2006-04-02 16:04 ` [PATCH 1/2] SCSI: implement scsi_eh_schedule_cmd() Tejun Heo
2006-04-02 16:06 ` [PATCH 2/2] SCSI: implement scsi_eh_schedule_host() Tejun Heo
2006-04-11 17:43 ` Jeff Garzik [this message]
2006-04-02 23:49 ` [PATCH 1/2] SCSI: implement scsi_eh_schedule_cmd() Luben Tuikov
2006-04-03 1:24 ` Tejun Heo
2006-04-11 17:41 ` Jeff Garzik
2006-04-11 21:28 ` Patrick Mansfield
2006-04-12 2:21 ` Tejun Heo
2006-04-12 8:24 ` Luben Tuikov
2006-04-12 16:18 ` Patrick Mansfield
2006-04-13 5:32 ` Tejun Heo
2006-04-14 8:49 ` Luben Tuikov
2006-04-14 12:02 ` Tejun Heo
2006-04-19 18:49 ` Luben Tuikov
2006-04-20 2:07 ` Tejun Heo
2006-04-20 13:01 ` Christoph Hellwig
2006-04-21 2:22 ` Tejun Heo
2006-04-20 19:23 ` Luben Tuikov
2006-04-21 2:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443BEAB3.9050704@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@SteelEye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=arjan@infradead.org \
--cc=hch@lst.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).