From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 2/2] SCSI: implement scsi_eh_schedule_host() Date: Tue, 11 Apr 2006 13:43:15 -0400 Message-ID: <443BEAB3.9050704@pobox.com> References: <20060401103857.GG13172@htj.dyndns.org> <442EDF1F.6000001@pobox.com> <442F25BD.8040000@gmail.com> <20060402160414.GM13172@htj.dyndns.org> <20060402160646.GN13172@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060402160646.GN13172@htj.dyndns.org> Sender: linux-scsi-owner@vger.kernel.org To: Tejun Heo Cc: hch@lst.de, James.Bottomley@SteelEye.com, alan@lxorguk.ukuu.org.uk, albertcc@tw.ibm.com, arjan@infradead.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org List-Id: linux-ide@vger.kernel.org Tejun Heo wrote: > This patch implements scsi_eh_schedule_host() which provides a way to > directly invoke SCSI EH without SCSI command from drivers implementing > ->eh_strategy_handler. This allows such drivers to use EH to handle > exception conditions which are not associated with particular SCSI > command. > > Signed-off-by: Tejun Heo > > --- > > Jeff, I think using separate variable (->host_eh_scheduled) is the > simplest way to implement this. Adding more semantics to ->host_busy > and failed doesn't sound very attractive to me. ACK, I reviewed the existing uses of host_busy and host_error (not too many), and this should be OK. However, I continue to be nervous being in the error handler when host_busy and host_error are zero. Jeff