From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
hch@lst.de, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] SCSI: fix scsi_kill_request() busy count handling
Date: Tue, 11 Apr 2006 13:44:26 -0400 [thread overview]
Message-ID: <443BEAFA.8010104@pobox.com> (raw)
In-Reply-To: <20060411082753.GA387@htj.dyndns.org>
Tejun Heo wrote:
> scsi_kill_request() completes requests via normal SCSI completion path
> which decrements busy counts; however, requests which get passed to
> scsi_kill_request() aren't holding busy counts and scsi_kill_request()
> don't increment them before invoking completion path resulting in
> incorrect busy counts. Bump up busy counts before invoking completion
> path.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
ACK.
As with the other two SCSI core patches, we're blocked on linux-scsi people.
Same response as the other two: if nobody complains, and nobody merges
into scsi-misc-2.6 in a sane amount of time, I'll push it into libata.
Jeff
prev parent reply other threads:[~2006-04-11 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 8:27 [PATCH] SCSI: fix scsi_kill_request() busy count handling Tejun Heo
2006-04-11 17:44 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443BEAFA.8010104@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@SteelEye.com \
--cc=hch@lst.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).