From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] SCSI: fix scsi_kill_request() busy count handling Date: Tue, 11 Apr 2006 13:44:26 -0400 Message-ID: <443BEAFA.8010104@pobox.com> References: <20060411082753.GA387@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:14214 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1750826AbWDKRob (ORCPT ); Tue, 11 Apr 2006 13:44:31 -0400 In-Reply-To: <20060411082753.GA387@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: James Bottomley , hch@lst.de, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org Tejun Heo wrote: > scsi_kill_request() completes requests via normal SCSI completion path > which decrements busy counts; however, requests which get passed to > scsi_kill_request() aren't holding busy counts and scsi_kill_request() > don't increment them before invoking completion path resulting in > incorrect busy counts. Bump up busy counts before invoking completion > path. > > Signed-off-by: Tejun Heo ACK. As with the other two SCSI core patches, we're blocked on linux-scsi people. Same response as the other two: if nobody complains, and nobody merges into scsi-misc-2.6 in a sane amount of time, I'll push it into libata. Jeff