From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: alan@lxorguk.ukuu.org.uk, axboe@suse.de, albertcc@tw.ibm.com,
lkosewsk@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/3] libata: prefix sata register print outs with 0x
Date: Wed, 12 Apr 2006 10:20:46 +0900 [thread overview]
Message-ID: <443C55EE.9020009@gmail.com> (raw)
In-Reply-To: <443BE634.7060406@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Prefix SStatus and SControl values with 0x as they are hex.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> NAK, libata always prints out device id, register, etc. values in hex.
> Basically anything other than things like sectors or bytes is printed in
> hex. Therefore, the "0x" is largely redundant.
>
> The prefix/base is implicit in the context.
>
The reason why I submitted this patch was messages like the following...
ata2: SATA link down (SStatus 11 SControl 310)
When it was three digits, it was okay. But two or just one digits look
just weird. Maybe what's needed is %03.
Well, no big deal either way.
--
tejun
next prev parent reply other threads:[~2006-04-12 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 13:26 [PATCHSET 3/9] misc ata_bus_probe() updates Tejun Heo
2006-04-11 13:26 ` [PATCH 3/3] libata: prefix sata register print outs with 0x Tejun Heo
2006-04-11 17:24 ` Jeff Garzik
2006-04-12 1:20 ` Tejun Heo [this message]
2006-04-11 13:26 ` [PATCH 1/3] libata: disable failed devices only once in ata_bus_probe() Tejun Heo
2006-04-11 17:22 ` Jeff Garzik
2006-04-11 13:26 ` [PATCH 2/3] libata: cosmetic update to ata_bus_probe() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443C55EE.9020009@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).