linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: albertl@mail.com
Cc: linux-ide@vger.kernel.org,
	Jonathan Benson <airbatica@verizon.net>,
	Tejun Heo <htejun@gmail.com>,
	Carlos Pardo <Carlos.Pardo@siliconimage.com>,
	Doug Maxey <dwm@maxeymade.com>, Brian King <brking@us.ibm.com>
Subject: Re: [PATCH/RFC] libata: turn on the ATAPI DMADIR support per word 62 (revised)
Date: Thu, 20 Apr 2006 18:51:13 -0400	[thread overview]
Message-ID: <44481061.30902@garzik.org> (raw)
In-Reply-To: <44446C6C.702@tw.ibm.com>

Albert Lee wrote:
> Summary:
>   SiI 3611 is currently the only known chip that needs DMADIR.
> Since SiI 3611 doesn't implement the ATA-7 word 62 or mangle identify
> packet device data, it's hard to check the chip and turn on the DMADIR
> support automatically. (Currently the libata DMADIR support can be 
> turned on manually by module parameter.)

Wonderful test report, thanks a _bunch_ for investigating this.


> To turn on the DMADIR support automatically, maybe we can check whether
> the ATAPI device is bridged (by ata_dev_knobble()). If bridged, we can
> try to issue a ATAPI DMA read command to check if ATAPI DMA works.
> If not work, then try turning on DMADIR or turn off ATAPI DMA.

Sounds like more complexity than its worth, for one non-spec-compliant 
bridge chip.  The module option gets the 3611 going, so IMO the current 
level of support is adequate.

BTW, I found a 3611 here, and put it into my primary fileserver, 
attaching to a DMA-capable PATA CD-RW drive.

	Jeff



      reply	other threads:[~2006-04-20 22:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-07  2:01 libata machine check on Alpha Jonathan Benson
2006-04-07  6:18 ` Albert Lee
2006-04-07  6:39 ` [PATCH/RFC] libata: turn on the ATAPI DMA DIR support per word 62 Albert Lee
2006-04-07  6:47   ` Jeff Garzik
2006-04-07 10:21     ` Albert Lee
2006-04-07 10:46       ` [PATCH/RFC] libata: turn on the ATAPI DMADIR support per word 62 (revised) Albert Lee
2006-04-07 17:54         ` Jeff Garzik
2006-04-18  4:34           ` Albert Lee
2006-04-20 22:51             ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44481061.30902@garzik.org \
    --to=jeff@garzik.org \
    --cc=Carlos.Pardo@siliconimage.com \
    --cc=airbatica@verizon.net \
    --cc=albertl@mail.com \
    --cc=brking@us.ibm.com \
    --cc=dwm@maxeymade.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).