Re: Schedule for adding pata to kernel?

[Albert Lee <albertcc@tw.ibm.com>]

Tejun Heo wrote:
> On Thu, Apr 20, 2006 at 06:48:31PM -0400, Jeff Garzik wrote:
> 
>>Tejun Heo wrote:
>>
>>>Hello, all.
>>>
>>>[adding Jeff and linux-ide to cc list]
>>>
>>>On Tue, Apr 18, 2006 at 01:00:13PM +0100, Alan Cox wrote:
>>>
>>>>On Maw, 2006-04-18 at 13:44 +0200, Fabio Comolli wrote:
>>>>
>>>>>In case PIIX/ICH driver should not make it in 2.6.17, are you planning
>>>>>to release patches for 2.6.17-rc release cycle?
>>>>
>>>>I've been on holiday and am now tied up in other work until the start of
>>>>May, at which point Jeff goes off and gets married so there may be some
>>>>delay.
>>>>
>>>>2.6.17-rc actually has 95% of the stuff needed to drop the PATA drivers
>>>>in and I will try to do patches at least versus 2.6.17 final. The -rcs
>>>>will depend upon available time and also what gets integrated that
>>>>causes additional work (notably Tejun Ho's stuff will make much merge
>>>
>>>BTW, my name is Tejun Heo.  Tejun Ho sounds horrible in Korean.
>>>
>>>
>>>>work, although its work I'm very glad to do as the improvements and
>>>>hotplug support are all needed).
>>>
>>>I'm currently working on port multiplier support.  My working tree now
>>>successfully probes and attaches all devices over the PM and I'm
>>>currently trying to get EH and hotplug to work with it nicely.
>>>EH/hotplug are being changed to support PM.  Effects on LLDDs are
>>>minimal but you can probably save some work by waiting for the next
>>>round of patches before porting to new EH.
>>>
>>>I think/hope this can be finished in this week and bombard Jeff with
>>>patches (updated EH, NCQ, hotplug and PM) before the weekend, so that
>>>Jeff can have some time to review and hopefully merge some of it into
>>>#upstream before he goes off on honeymoon.  In some convoluted way,
>>>the patches will be my marriage gift, heh heh.
>>>
>>>Jeff, *BIG* congratulations.  I wish you a great marriage.
>>
>>Thanks :)  And thanks for working on this stuff...  As you see, once the 
>>EH hurdle is cleared, it is much easier to add new features.  New 
>>features will start flooding in, from you and others.
>>
>>BTW don't forget we want to push Albert's irq-pio branch into upstream 
>>sometime soon after your EH work settles.  I would put irq-pio in front 
>>of NCQ and PM, particularly.
> 
> 
> Hmmm... EH, NCQ, PM stuff doesn't really interfere with irq-pio.  The
> only thing which needs special attention is hotplug support for
> sata_sil as the driver requires PIO HSM implementation but needs to
> use its own interrupt handler.  So, we need to separate out PIO HSM
> from ata_host_intr() and allow LLDD irq handlers to drive it.

 In the irq-pio branch, the HSM code has been seperated out from
ata_host_intr() to ata_hsm_move() as static function currently.
Maybe we can export ata_hsm_move() as external?
I didn't look into how sil3611 hotplug interacts with PIO HSM.
Don't know whether this is good enough for the need of sata_sil.

--
albert