From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, axboe@suse.de, albertcc@tw.ibm.com,
lkosewsk@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCHSET 8/9] prep for hotplug support
Date: Thu, 27 Apr 2006 06:36:55 -0400 [thread overview]
Message-ID: <44509EC7.70807@pobox.com> (raw)
In-Reply-To: <44509C98.80301@gmail.com>
Tejun Heo wrote:
> Yeah, Forrest pointed out the same thing and I've converted hotplug_wq
> to single threaded variant, which should be enough for SCSI hotplugging.
> For ata_wq, I think it's wiser to keep it multi-threaded for the time
> being. Maybe what should be done is to allocate a single threaded
> workqueue per host_set.
One thread per host_set would suck for any situation where that's doing
ATAPI or PIO tasks. Would love to find a good metric...
> $BIGNUM CPU boxes tend to have $BIGNUM GB of memories, so multithreaded
> wq might not be that critical resource-wise. But, still, inefficient
That's a bad assumption on modern machines. Think of a single 16-core,
8-thread SPARC Niagara CPU, for example :)
Jeff
next prev parent reply other threads:[~2006-04-27 10:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 14:06 [PATCHSET 8/9] prep for hotplug support Tejun Heo
2006-04-11 14:06 ` [PATCH 05/13] libata-hp: call ata_dev_init() from ata_bus_probe() Tejun Heo
2006-04-11 14:06 ` [PATCH 06/13] libata-hp: prepare for persistent device flags Tejun Heo
2006-04-11 14:06 ` [PATCH 07/13] libata-hp: implement ap->orig_sata_spd_limit Tejun Heo
2006-04-27 9:19 ` Jeff Garzik
2006-04-27 10:18 ` Tejun Heo
2006-04-11 14:06 ` [PATCH 03/13] libata-hp: implement ata_dev_init() Tejun Heo
2006-04-11 14:06 ` [PATCH 02/13] libata-hp: add more SERR_* constants in preparation for hotplug support Tejun Heo
2006-04-11 14:06 ` [PATCH 04/13] libata-hp: make some fields of ata_device persistent Tejun Heo
2006-04-11 14:06 ` [PATCH 08/13] libata-hp: move device enable/disable out of ata_bus_probe() Tejun Heo
2006-04-11 14:06 ` [PATCH 01/13] libata-hp: separate out __ata_scsi_find_dev() Tejun Heo
2006-04-11 14:06 ` [PATCH 13/13] libata-hp: add ata_hotplug_wq Tejun Heo
2006-04-13 6:11 ` zhao, forrest
2006-04-13 6:33 ` Tejun Heo
2006-04-11 14:06 ` [PATCH 09/13] libata-hp: prepare ata_bus_probe() for hotplug Tejun Heo
2006-04-11 14:06 ` [PATCH 10/13] libata-hp: make ata_bus_probe() extern Tejun Heo
2006-04-11 14:06 ` [PATCH 11/13] libata-hp: add hotplug flags and flag handling functions Tejun Heo
2006-04-11 14:06 ` [PATCH 12/13] libata-hp: store attached SCSI device Tejun Heo
2006-04-27 9:20 ` Jeff Garzik
2006-04-12 1:41 ` [PATCHSET 8/9] prep for hotplug support Tejun Heo
2006-04-27 9:22 ` Jeff Garzik
2006-04-27 10:27 ` Tejun Heo
2006-04-27 10:36 ` Jeff Garzik [this message]
2006-04-27 10:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44509EC7.70807@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkosewsk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).