Re: [PATCH] 2.6.xx: sata_mv: another critical fix

[Mark Lord <liml@rtr.ca>]

> I've added two Marvell MV88SX6081 controller (total of three now),
> removed the bad disks from the system (all I hope), added new ones
> (total of 12, 300GB Maxtor DiamondMax, connected to the controllers
> now (each four disks)), and added two 2.5" disks for the OS (connected
> to the onboard Nvidia).
> 
> I also upgraded to 2.6.17-rc3-mm1, which seemed oke using badblocks, but
> dd and mdadm give trouble.
> 
> First of all, Linux does not always see all disks during boot. Sometimes
> one or two disks are missing. I haven't checked yet if these are always
...
> [  416.910684] ata12: SATA max UDMA/133 cmd 0x0 ctl 0xFFFFC200000B8120 bmdma 0x0 irq 21
> [  417.016463] BUG: warning at drivers/scsi/sata_mv.c:1904/__msleep()
> [  417.053468] 
> [  417.053469] Call Trace: <IRQ> <ffffffff803e8c33>{__mv_phy_reset+242}
> [  417.099671]        <ffffffff803e811f>{mv_channel_reset+133} <ffffffff803e9297>{mv_interrupt+568}
> [  417.152658]        <ffffffff8020ec91>{handle_IRQ_event+41} <ffffffff80282bbf>{__do_IRQ+155}
> [  417.203033]        <ffffffff8025dd91>{do_IRQ+60} <ffffffff8025be52>{default_idle+0}
> [  417.249254]        <ffffffff80256178>{ret_from_intr+0} <EOI> <ffffffff80258d00>{thread_return+86}
> [  417.302853]        <ffffffff8025be7f>{default_idle+45} <ffffffff80243c0f>{cpu_idle+98}
> [  417.350632]        <ffffffff806e8b74>{start_secondary+1127}
> [  420.701529] ata5: dev 0 cfg 49:2f00 82:7c6b 83:7f09 84:4673 85:7c69 86:3e21 87:4663 88:007f
> [  420.701533] ata5: dev 0 ATA-7, max UDMA/133, 586114704 sectors: LBA48
...

> [55973.577770] ata24: translated ATA stat/err 0x50/01 to SCSI SK/ASC/ASCQ 0x3/13/00
> [55973.622012] ata24: status=0x50 { DriveReady SeekComplete }
> [55973.654966] ata24: error=0x01 { AddrMarkNotFound }
> [55973.683740] sata_mv: PCI ERROR; PCI IRQ cause=0x40000100
...

Hi Sander,

I'm still debugging the chip/driver on the 2.6.16.xx series,
and my sata_mv.c code here is behaving well for most testers
thus far here.  I'm avoiding 2.6.17-* until sata_mv stabilizes
on the existing kernels.

Does the drive probing work for you on older kernels?

I'll email you privately and set you up with a better copy of sata_mv.c

Cheers