From: Jes Sorensen <jes@sgi.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Brent Casavant <bcasavan@sgi.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
akpm@osdl.org, jeremy@sgi.com
Subject: Re: [PATCH] Move various PCI IDs to header file
Date: Fri, 05 May 2006 07:45:52 +0200 [thread overview]
Message-ID: <445AE690.5030700@sgi.com> (raw)
In-Reply-To: <20060504173722.028c2b24.rdunlap@xenotime.net>
Randy.Dunlap wrote:
> On Thu, 4 May 2006 18:09:45 -0500 (CDT) Brent Casavant wrote:
>
>> Move various QLogic, Vitesse, and Intel storage
>> controller PCI IDs to the main header file.
>>
>> Signed-off-by: Brent Casavant <bcasavan@sgi.com>
>>
>> ---
>>
>> As suggested by Andrew Morton and Jes Sorenson.
>
> as compared to:
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=9b860b8c4bde5949b272968597d1426d53080532
I guess Andrew and I should be blamed for that. I Andrew suggested
putting the IDs in the 'right place' and I took the right place as being
the pci_ids.h file.
Can't say I agree with the recommendation, having them in pci_ids.h is
nice and clean and it allows one to go look through the list, instead
they now really become random hex values :( Brent's patch is a perfect
example of IDs being used in multiple places, ie. the qla1280 driver
and in the IOC4 driver, so the claim in that Documentation/ file doesn't
hold water.
Anyway, if this is the new rule, then I guess it's back to using the
ugly patch :(
Jes
next prev parent reply other threads:[~2006-05-05 5:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 23:09 [PATCH] Move various PCI IDs to header file Brent Casavant
2006-05-05 0:37 ` Randy.Dunlap
2006-05-05 5:45 ` Jes Sorensen [this message]
2006-05-05 13:34 ` Greg KH
2006-05-13 4:29 ` Jeff Garzik
2006-05-05 16:27 ` Randy.Dunlap
2006-05-05 22:37 ` Grant Coady
2006-05-08 7:55 ` Jes Sorensen
2006-05-08 8:31 ` Arjan van de Ven
2006-05-08 8:35 ` Jes Sorensen
2006-05-05 14:09 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445AE690.5030700@sgi.com \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=bcasavan@sgi.com \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).