From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH] Move various PCI IDs to header file Date: Mon, 08 May 2006 09:55:20 +0200 Message-ID: <445EF968.3080903@sgi.com> References: <20060504180614.X88573@chenjesu.americas.sgi.com> <20060504173722.028c2b24.rdunlap@xenotime.net> <445AE690.5030700@sgi.com> <0jkn52lnu505eb26plf5o7buertimg2e6v@4ax.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from omx1-ext.sgi.com ([192.48.179.11]:48276 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1750721AbWEHHzb (ORCPT ); Mon, 8 May 2006 03:55:31 -0400 In-Reply-To: <0jkn52lnu505eb26plf5o7buertimg2e6v@4ax.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Grant Coady Cc: "Randy.Dunlap" , Brent Casavant , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, akpm@osdl.org, jeremy@sgi.com Grant Coady wrote: > When I worked on pci_ids.h cleanup last year I didn't get a clear > idea of whether moving all #defines to the one header file was > desired. Last I looked there were heaps of them scattered all > over. Is there a preferred model for placing these #defines? > > Grant. According to the document Randy referenced, the preferred place for *new* defines is to stick them in the local files where they are used. I don't think there is any preference for moving the out of pci_ids.h as it would just cause patch noise for the sake of making noise. So much for being able to go through the pci_ids.h file to get an idea about whether or not a device may have a chance of being supported :( Jes