From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: ata_piix failure on ich6m
Date: Fri, 12 May 2006 23:42:34 -0400 [thread overview]
Message-ID: <446555AA.9000603@pobox.com> (raw)
In-Reply-To: <44629E68.3020302@gmail.com>
Tejun Heo wrote:
> Matthew Garrett wrote:
>> Hi,
>>
>> We've got an ich6m system (a Toshiba Portege S100). ata_piix attempts
>> to drive the chipset, but fails - however, it doesn't bail out. As a
>> result it remains bound to the device and ahci isn't loaded.
>>
>> I've attached the lspci output for the chipset. A few things to note are:
>>
>> 1) The AHCI BAR is set
>> 2) The SCC register identifies it as an AHCI controller
>> 3) Bits 2 and 0 of the PCS are set, which the spec claims indicates
>> that the port is to be controlled as an ahci device.
>>
>> So, my question is effectively: why does ata_piix attempt to disable
>> ahci rather than simply letting the ahci driver bind? Points (1) and
>> (2) seem to be checked by the code, but I'm guessing that in the case
>> of (3) it should just return ENODEV and let ahci be run instead. If
>> so, should I code up a patch?
>>
>
> I'm not very sure but it might be historical. ahci got implemented
> after ata_piix and in the meantime ata_piix must have handled all it
> could. Can you verify whether modifying the code to return -ENODEV work
> for your machine? If so, that could be the correct solution but I'm a
> bit worried because it could change probing order or fail to enable
> devices it used to. Maybe we need a hack to return -ENODEV iff ahci is
> there to handle the device.
It's definitely historical. I'm pretty frazzled now so I don't
remember. It may be that on ICH6, AHCI mode does not cause the PCI IDs
to change, so driver load order winds up dictating what gets used.
Jeff
prev parent reply other threads:[~2006-05-13 3:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 23:56 ata_piix failure on ich6m Matthew Garrett
2006-05-11 2:16 ` Tejun Heo
2006-05-11 8:11 ` Matthew Garrett
2006-05-11 15:45 ` Randy.Dunlap
2006-05-11 16:16 ` Matthew Garrett
2006-05-13 3:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446555AA.9000603@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).